* [PATCH] 2.6.28 remove unused sil24_port_multiplier
@ 2009-01-07 1:59 Grant Grundler
2009-01-07 2:02 ` Tejun Heo
0 siblings, 1 reply; 3+ messages in thread
From: Grant Grundler @ 2009-01-07 1:59 UTC (permalink / raw)
To: Tejun Heo; +Cc: linux-ide
[-- Attachment #1: Type: text/plain, Size: 140 bytes --]
AFAICT, struct sil24_port_multiplier isn't used anywhere. Remove it.
Signed-off-by: Grant Grundler <grundler@google.com>
<Patch attached>
[-- Attachment #2: diff-2.6.28-rc8_sil24_dead_code-01 --]
[-- Type: application/octet-stream, Size: 348 bytes --]
diff --git a/drivers/ata/sata_sil24.c b/drivers/ata/sata_sil24.c
index ccee930..2590c22 100644
--- a/drivers/ata/sata_sil24.c
+++ b/drivers/ata/sata_sil24.c
@@ -51,13 +51,6 @@ struct sil24_sge {
__le32 flags;
};
-/*
- * Port multiplier
- */
-struct sil24_port_multiplier {
- __le32 diag;
- __le32 sactive;
-};
enum {
SIL24_HOST_BAR = 0,
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] 2.6.28 remove unused sil24_port_multiplier
2009-01-07 1:59 [PATCH] 2.6.28 remove unused sil24_port_multiplier Grant Grundler
@ 2009-01-07 2:02 ` Tejun Heo
[not found] ` <da824cf30901061822p7e3407epbffedb9455faaccd@mail.gmail.com>
0 siblings, 1 reply; 3+ messages in thread
From: Tejun Heo @ 2009-01-07 2:02 UTC (permalink / raw)
To: Grant Grundler; +Cc: linux-ide
Grant Grundler wrote:
> AFAICT, struct sil24_port_multiplier isn't used anywhere. Remove it.
>
> Signed-off-by: Grant Grundler <grundler@google.com>
>
> <Patch attached>
Indeed. Acked-by: Tejun Heo <tj@kernel.org> but can you please resend
with properly inlined patch?
Thanks.
--
tejun
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH #upstream-fixes] sata_sil24: remove unused sil24_port_multiplier
[not found] ` <da824cf30901061822p7e3407epbffedb9455faaccd@mail.gmail.com>
@ 2009-01-07 2:26 ` Tejun Heo
0 siblings, 0 replies; 3+ messages in thread
From: Tejun Heo @ 2009-01-07 2:26 UTC (permalink / raw)
To: Grant Grundler, Jeff Garzik, IDE/ATA development list
From: Grant Grundler <grundler@google.com>
AFAICT, struct sil24_port_multiplier isn't used anywhere. Remove it.
Signed-off-by: Grant Grundler <grundler@google.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
---
Sure thing. Here you go.
drivers/ata/sata_sil24.c | 7 -------
1 file changed, 7 deletions(-)
diff --git a/drivers/ata/sata_sil24.c b/drivers/ata/sata_sil24.c
index ccee930..2590c22 100644
--- a/drivers/ata/sata_sil24.c
+++ b/drivers/ata/sata_sil24.c
@@ -51,13 +51,6 @@ struct sil24_sge {
__le32 flags;
};
-/*
- * Port multiplier
- */
-struct sil24_port_multiplier {
- __le32 diag;
- __le32 sactive;
-};
enum {
SIL24_HOST_BAR = 0,
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-01-07 2:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-01-07 1:59 [PATCH] 2.6.28 remove unused sil24_port_multiplier Grant Grundler
2009-01-07 2:02 ` Tejun Heo
[not found] ` <da824cf30901061822p7e3407epbffedb9455faaccd@mail.gmail.com>
2009-01-07 2:26 ` [PATCH #upstream-fixes] sata_sil24: " Tejun Heo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).