From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tejun Heo Subject: Re: [PATCH #upstream-fixes] libata: implement and use HORKAGE_NOSETXFER Date: Wed, 07 Jan 2009 19:27:49 +0900 Message-ID: <496483A5.6020105@kernel.org> References: <1229894315.6931.17.camel@Thutmosis> <494EDDBE.3010306@shaw.ca> <494F65C1.80602@kernel.org> <1229947998.6045.10.camel@Thutmosis> <49505500.8080409@kernel.org> <1230126055.6430.17.camel@Thutmosis> <495886E7.7050204@kernel.org> <1230586376.11130.46.camel@Thutmosis> <1231282276.6376.13.camel@Thutmosis> <49640CE1.6070808@kernel.org> <20090107094043.580f5bf7@lxorguk.ukuu.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from hera.kernel.org ([140.211.167.34]:59608 "EHLO hera.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751081AbZAGK2S (ORCPT ); Wed, 7 Jan 2009 05:28:18 -0500 In-Reply-To: <20090107094043.580f5bf7@lxorguk.ukuu.org.uk> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Alan Cox Cc: linux--ide-momail.e4ward.com-linux--ide-vger.kernel.org-CDD-6w99-4@reply.e4ward.com, Jeff Garzik , Robert Hancock , peter.klotz@aon.at, linux-ide@vger.kernel.org Alan Cox wrote: > On Wed, 07 Jan 2009 11:01:05 +0900 > Tejun Heo wrote: > >> PIONEER DVD-RW DVRTD08 times out SETXFER if no media is present. The >> device is SATA and simply skipping SETXFER works around the problem. >> Implement ATA_HORKAGE_NOSETXFER and apply it to the device. > > NAK > > Sorry you can't just blindly do this because some of the controllers snoop > the SETXFER command to set their timings and whether they expect DMA. Also > we've no idea if this is a bug in a specific firmware revision, a quirky > pata/sata bridge or a timing problem of some sort. I think it'll generally be okay for SATA unless it's bridged over to PATA controller. Any other ideas? Thanks. -- tejun