From: Mark Lord <liml@rtr.ca>
To: Harri Olin <harri.olin@gmail.com>
Cc: IDE/ATA development list <linux-ide@vger.kernel.org>,
Brian Rademacher <rad@radfiles.net>,
Eamonn Hamilton <EAMONN.HAMILTON@saic.com>
Subject: Re: sata_mv: trial fix for lost NCQ interrupts
Date: Wed, 14 Jan 2009 17:06:32 -0500 [thread overview]
Message-ID: <496E61E8.5010602@rtr.ca> (raw)
In-Reply-To: <496E53DD.6040408@gmail.com>
Harri Olin wrote:
..
> I tried the patch and it works as well as it did without the patch. That
> is to say, timeouts still happen, every couple of minutes on moderate
..
Yup. On reflection, that patch has no effect, other than speeding things up.
However, I think I *have* found the actual bug this time.
Try this patch and report back again.
--- linux-2.6.28/drivers/ata/sata_mv.c 2009-01-13 15:57:11.000000000 -0500
+++ linux/drivers/ata/sata_mv.c 2009-01-14 16:56:38.000000000 -0500
@@ -883,7 +883,7 @@
struct mv_host_priv *hpriv = ap->host->private_data;
int hardport = mv_hardport_from_port(ap->port_no);
void __iomem *hc_mmio = mv_hc_base_from_port(
- mv_host_base(ap->host), hardport);
+ mv_host_base(ap->host), ap->port_no);
u32 hc_irq_cause, ipending;
/* clear EDMA event indicators, if any */
next prev parent reply other threads:[~2009-01-14 22:06 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-13 21:17 sata_mv: trial fix for lost NCQ interrupts Mark Lord
2009-01-14 21:06 ` Harri Olin
2009-01-14 21:26 ` Jeff Garzik
2009-01-14 22:08 ` Mark Lord
2009-01-14 22:06 ` Mark Lord [this message]
2009-01-14 23:18 ` Harri Olin
2009-01-14 23:22 ` Brian Rademacher
2009-01-15 2:53 ` Mark Lord
2009-01-15 13:06 ` Artem Bokhan
2009-01-16 17:03 ` [PATCH] sata_mv: fix timeouts on lower ports of 508x/6081 chips Mark Lord
2009-01-16 20:08 ` Harri Olin
2009-01-17 2:10 ` Brian Rademacher
2009-01-14 22:01 ` sata_mv: trial fix for lost NCQ interrupts Brian Rademacher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=496E61E8.5010602@rtr.ca \
--to=liml@rtr.ca \
--cc=EAMONN.HAMILTON@saic.com \
--cc=harri.olin@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=rad@radfiles.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).