From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
To: Atsushi Nemoto <anemo@mba.ocn.ne.jp>,
Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Cc: linux-ide@vger.kernel.org
Subject: Re: [PATCH] tx4938ide: Fix build error due to read_sff_dma_status moving
Date: Thu, 15 Jan 2009 16:52:32 +0300 [thread overview]
Message-ID: <496F3FA0.8060807@ru.mvista.com> (raw)
In-Reply-To: <4968DA1B.2020702@ru.mvista.com>
Hello, I wrote:
>> Signed-off-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
> Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
>> diff --git a/drivers/ide/tx4938ide.c b/drivers/ide/tx4938ide.c
>> index b4ef218..d909534 100644
>> --- a/drivers/ide/tx4938ide.c
>> +++ b/drivers/ide/tx4938ide.c
>> @@ -202,7 +202,6 @@ static const struct ide_tp_ops tx4938ide_tp_ops = {
>> .exec_command = ide_exec_command,
>> .read_status = ide_read_status,
>> .read_altstatus = ide_read_altstatus,
>> - .read_sff_dma_status = ide_read_sff_dma_status,
>>
>> .set_irq = ide_set_irq,
>>
>
>
> Oops. Don;t know how I managed to miss this one...
Ah, I know how: this driver was added after I created my patch, and I
didn't re-check for the missing pieces several months later, when preparing
the patch for submission. :-/
MBR, Sergei
prev parent reply other threads:[~2009-01-15 13:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-10 17:20 [PATCH] tx4938ide: Fix build error due to read_sff_dma_status moving Atsushi Nemoto
2009-01-10 17:25 ` Sergei Shtylyov
2009-01-11 16:31 ` Bartlomiej Zolnierkiewicz
2009-01-15 13:52 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=496F3FA0.8060807@ru.mvista.com \
--to=sshtylyov@ru.mvista.com \
--cc=anemo@mba.ocn.ne.jp \
--cc=bzolnier@gmail.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).