From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [patch 2.6.29-rc2] palm_bk3710 buildfix Date: Mon, 19 Jan 2009 11:35:02 +0300 Message-ID: <49743B36.90909@ru.mvista.com> References: <200901180833.53969.david-b@pacbell.net> <4973635A.2050302@ru.mvista.com> <200901181629.48348.david-b@pacbell.net> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from h155.mvista.com ([63.81.120.155]:41396 "EHLO imap.sh.mvista.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1757376AbZASIfL (ORCPT ); Mon, 19 Jan 2009 03:35:11 -0500 In-Reply-To: <200901181629.48348.david-b@pacbell.net> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: David Brownell Cc: bzolnier@gmail.com, linux-ide@vger.kernel.org, Kevin Hilman Hello. David Brownell wrote: > On Sunday 18 January 2009, Sergei Shtylyov wrote: > >>> Someone should fix hw_regs_t to neither be a typedef, nor >>> use "unsigned long" where it should use "void __iomem *". >>> >> It cannot use pointers of course -- as the addresses can be I/O ports. >> > > It could use the ioread*() calls, which take pointers > and handle both types of I/O in a type-safe manner. > Probably they can... though using those would only slow down register access on x86. > - Dave WBR, Sergei