From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [PATCH 2/6] ide: move SFF I/O code to ide-io-sff.c Date: Mon, 19 Jan 2009 21:46:25 +0300 Message-ID: <4974CA81.1050506@ru.mvista.com> References: <20090119130309.24745.40877.sendpatchset@localhost.localdomain> <20090119130322.24745.76137.sendpatchset@localhost.localdomain> <49748B95.9080105@ru.mvista.com> <200901191523.15240.bzolnier@gmail.com> <49748E43.4030009@ru.mvista.com> <20090119173701.13fd24c6@lxorguk.ukuu.org.uk> <4974C030.5020509@ru.mvista.com> <20090119183607.5ee804e1@lxorguk.ukuu.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20090119183607.5ee804e1@lxorguk.ukuu.org.uk> Sender: linux-kernel-owner@vger.kernel.org To: Alan Cox Cc: Bartlomiej Zolnierkiewicz , linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-ide@vger.kernel.org Alan Cox wrote: >>>BTW if you moved to ioreadX you could get rid of almost all the readb/inb >>>special casing. >> And burden the driver code with function calls ISO in/out instructions, at >>least on x86. It's somewhat arguable move. > And exactly how do you think the IDE accessors in the file get called ? Tried looking at how in*()/out*() are defined on x86? > It's already making function calls, without the benefit of inlining and I'm afraid you're wrong here. MBR, Sergei