From: Tejun Heo <tj@kernel.org>
To: JosephChan@via.com.tw
Cc: alan@lxorguk.ukuu.org.uk, linux-ide@vger.kernel.org,
sshtylyov@ru.mvista.com
Subject: Re: [PATCH 1/2 v1] pata_via.c: support VX855 and future chips whose IDE controller use 0x0571.
Date: Fri, 23 Jan 2009 08:35:14 +0900 [thread overview]
Message-ID: <497902B2.2050700@kernel.org> (raw)
In-Reply-To: <C80EF34A3D2E494DBAF9AC29C7AE4EB80889B843@exchtp03.taipei.via.com.tw>
JosephChan@via.com.tw wrote:
>> for (config = via_isa_bridges; config->id !=
>> PCI_DEVICE_ID_VIA_ANON; config++)
>>
>> That way, you won't need any special handling and just use "UNKNOWN"
>> as the name of the wildcard entry.
>>
>
> How about this? :)
> I also found that if I modified to the following line.
> for (config = via_isa_bridges; config->id != PCI_DEVICE_ID_VIA_ANON; config++)
> I need to move the PCI_DEVICE_ID_VIA_ANON to the end of via_isa_bridges.
> Or the for loop will exit at 1st check.
Looks good to me. :-)
Thanks.
--
tejun
next prev parent reply other threads:[~2009-01-22 23:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-16 11:46 [PATCH 1/2 v1] pata_via.c: support VX855 and future chips whose IDE controller use 0x0571 JosephChan
2009-01-16 14:34 ` Tejun Heo
2009-01-19 11:26 ` JosephChan
2009-01-22 1:19 ` Tejun Heo
2009-01-22 11:37 ` JosephChan
2009-01-22 23:35 ` Tejun Heo [this message]
2009-01-23 3:15 ` JosephChan
2009-01-23 3:33 ` Tejun Heo
-- strict thread matches above, loose matches on Subject: below --
2009-01-15 13:04 JosephChan
2009-01-15 13:40 ` Alan Cox
2009-01-16 0:57 ` JosephChan
2009-01-16 12:15 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=497902B2.2050700@kernel.org \
--to=tj@kernel.org \
--cc=JosephChan@via.com.tw \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-ide@vger.kernel.org \
--cc=sshtylyov@ru.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).