From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [PATCH] ide/libata: fix ata_id_is_cfa() Date: Fri, 23 Jan 2009 16:53:05 +0300 Message-ID: <4979CBC1.3040106@ru.mvista.com> References: <200901231615.38011.sshtylyov@ru.mvista.com> <20090123133352.60add80e@lxorguk.ukuu.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from h155.mvista.com ([63.81.120.155]:60505 "EHLO imap.sh.mvista.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1753818AbZAWNwf (ORCPT ); Fri, 23 Jan 2009 08:52:35 -0500 In-Reply-To: <20090123133352.60add80e@lxorguk.ukuu.org.uk> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Alan Cox Cc: bzolnier@gmail.com, jgarzik@pobox.com, linux-ide@vger.kernel.org, gdu@mns.spb.ru Hello. Alan Cox wrote: >>When checking for CFA feature set support, ata_id_is_cfa() tests bit 2 in word >>82 of the identify data instead the word 83. It also checks the ATA revision >>in the word 80 instead of usual validity check for the words 82-83 -- word 83 >>bit 14 set, bit 15 cleared. > The word 82 validity bit is not sufficient as that bit is itself not There's no word 82 validity bits, its validity bits are in word 83. > defined in ATA < 3. Otherwise the change looks correct. Well, then we need to fix every case of using *only* the validity bits in ata.h. Go ahead. ;-) > Alan WBR, Sergei