From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [PATCH] ide/libata: fix ata_id_is_cfa() Date: Mon, 26 Jan 2009 22:45:00 +0300 Message-ID: <497E12BC.1080809@ru.mvista.com> References: <200901231615.38011.sshtylyov@ru.mvista.com> <497B9EE4.8010807@ru.mvista.com> <497E0548.80904@ru.mvista.com> <20090126190801.7d198246@lxorguk.ukuu.org.uk> <497E0F76.6020606@ru.mvista.com> <20090126193550.27eef301@lxorguk.ukuu.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from h155.mvista.com ([63.81.120.155]:4120 "EHLO imap.sh.mvista.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1752469AbZAZToa (ORCPT ); Mon, 26 Jan 2009 14:44:30 -0500 In-Reply-To: <20090126193550.27eef301@lxorguk.ukuu.org.uk> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Alan Cox Cc: bzolnier@gmail.com, jgarzik@pobox.com, linux-ide@vger.kernel.org, gdu@mns.spb.ru Alan Cox wrote: >>>+ if (id[ATA_ID_MAJOR_VER] == 0xFFFF) >>>+ return 0; >>>+ return (id[ATA_ID_MAJOR_VER] & (1 << v)) ? 1 : 0; >> Refer to afa_dev_cf_sata() on how it's done in really optimal way. > To what ? - there is no ata or afa_dev_cf_sata ? Very funny. Meant to be ata_dev_is_sata(), of course. MBR, Sergei