Re: [PATCH 2/5] pata-rb532-cf: replace rb532_pata_finish_io()

[Jeff Garzik <jeff@garzik.org>]

Phil Sutter wrote:
> Since the delay used internally is just the same as ata_sff_pause()
> uses, rb532_pata_finish_io() does exactly the same as ata_sff_pause()
> and thus can be replaced by the later one.
> 
> Signed-off-by: Phil Sutter <n0-1@freewrt.org>
> ---
>  drivers/ata/pata_rb532_cf.c |   15 ++-------------
>  1 files changed, 2 insertions(+), 13 deletions(-)
> 
> diff --git a/drivers/ata/pata_rb532_cf.c b/drivers/ata/pata_rb532_cf.c
> index cd2eecd..9305eee 100644
> --- a/drivers/ata/pata_rb532_cf.c
> +++ b/drivers/ata/pata_rb532_cf.c
> @@ -54,22 +54,11 @@ struct rb532_cf_info {
>  
>  /* ------------------------------------------------------------------------ */
>  
> -static inline void rb532_pata_finish_io(struct ata_port *ap)
> -{
> -	struct ata_host *ah = ap->host;
> -	struct rb532_cf_info *info = ah->private_data;
> -
> -	/* FIXME: Keep previous delay. If this is merely a fence then
> -	   ata_sff_sync might be sufficient. */
> -	ata_sff_dma_pause(ap);
> -	ndelay(RB500_CF_IO_DELAY);
> -}

ACK patches 2-5, but they don't apply to upstream (plus patch #1)