From: Mark Lord <liml@rtr.ca>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Sergei Shtylyov <sshtylyov@ru.mvista.com>,
bzolnier@gmail.com, jgarzik@pobox.com, linux-ide@vger.kernel.org,
gdu@mns.spb.ru
Subject: Re: [PATCH] ide/libata: fix ata_id_is_cfa() (take 3)
Date: Tue, 27 Jan 2009 10:56:29 -0500 [thread overview]
Message-ID: <497F2EAD.4080705@rtr.ca> (raw)
In-Reply-To: <20090127133841.2405e649@lxorguk.ukuu.org.uk>
Alan Cox wrote:
> On Tue, 27 Jan 2009 17:19:52 +0400
> Sergei Shtylyov <sshtylyov@ru.mvista.com> wrote:
>
>> When checking for the CFA feature set support, ata_id_is_cfa() tests bit 2 in
>> word 82 of the identify data instead the word 83; it also checks the ATA/PI
>> version support in the word 80 (which the CompactFlash specifications have as
>> reserved), this having no slightest chance to work on the modern CF cards that
>> don't have 0x848A in the word 0...
>>
>> Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
>
> Acked-by: Alan Cox <number6@the-village.bc.nu>
..
Any chance you two could figure out this one below?
It *is* a CF card, but doesn't show up as such.
/dev/sda:
044a 3fff 0000 000f 0000 0240 003f 03bc
0000 0000 5052 4554 4543 2020 2020 2020
3031 3233 3541 4545 0002 0002 0004 3230
3038 3038 3035 4346 2020 2020 2020 2020
2020 2020 2020 2020 2020 2020 2020 2020
2020 2020 2020 2020 2020 2020 2020 8001
0000 0300 0000 0200 0000 0007 3fff 000f
003f 3c4f 00ec 0100 0000 03bc 0000 0007
0003 0078 0078 0078 0078 0000 0000 0000
0000 0000 0000 0000 0000 0000 0000 0000
0010 0000 700b 400c 4003 0001 0000 0003
207f 0001 0000 0000 fffe 600f 0000 0000
0000 0000 0000 0000 0000 0000 0000 0000
0000 0000 0000 0000 0000 0000 0000 0000
0000 0000 0000 0000 0000 0000 0000 0000
0000 0000 0000 0000 0000 0000 0000 0000
0009 0000 0000 0000 0000 0000 0000 0000
0000 0000 0000 0000 0000 0000 0000 0000
0000 0000 0000 0000 0000 0000 0000 0000
0000 0000 0000 0000 0000 0000 0000 0000
81f4 0000 0000 0092 001b 0000 0000 0000
0000 0000 0000 0000 0000 0000 0000 0000
0000 0000 0000 0000 0000 0000 0000 0000
0000 0000 0000 0000 0000 0000 0000 0000
0000 0000 0000 0000 0000 0000 0000 0000
0000 0000 0000 0000 0000 0000 0000 0000
0000 0000 0000 0000 0000 0000 0000 0000
0000 0000 0000 0000 0000 0000 0000 0000
0000 0000 0000 0000 0000 0000 0000 0000
0000 0000 0000 0000 0000 0000 0000 0000
0000 0000 0000 0000 0000 0000 0000 0000
0000 0000 0000 0000 0000 0000 0000 0000
next prev parent reply other threads:[~2009-01-27 15:56 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-27 13:19 [PATCH] ide/libata: fix ata_id_is_cfa() (take 3) Sergei Shtylyov
2009-01-27 13:38 ` Alan Cox
2009-01-27 13:49 ` Jeff Garzik
2009-01-27 16:09 ` Sergei Shtylyov
2009-01-27 16:21 ` Sergei Shtylyov
2009-01-27 15:56 ` Mark Lord [this message]
2009-01-27 16:16 ` Sergei Shtylyov
2009-01-27 16:18 ` Mark Lord
2009-01-27 16:26 ` Sergei Shtylyov
2009-01-27 16:28 ` Mark Lord
2009-01-28 7:51 ` Dmitry Gryazin
2009-01-28 15:03 ` ide/libata: fix ata_id_is_cfa() .. hdparm-9.10 Mark Lord
2009-01-27 17:41 ` [PATCH] ide/libata: fix ata_id_is_cfa() (take 3) Mark Lord
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=497F2EAD.4080705@rtr.ca \
--to=liml@rtr.ca \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=bzolnier@gmail.com \
--cc=gdu@mns.spb.ru \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=sshtylyov@ru.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).