From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
bzolnier@gmail.com, linux-ide@vger.kernel.org, gdu@mns.spb.ru
Subject: Re: [PATCH] ide/libata: fix ata_id_is_cfa() (take 3)
Date: Tue, 27 Jan 2009 19:09:04 +0300 [thread overview]
Message-ID: <497F31A0.7010104@ru.mvista.com> (raw)
In-Reply-To: <497F10D1.5020400@pobox.com>
Jeff Garzik wrote:
>>> When checking for the CFA feature set support, ata_id_is_cfa() tests
>>> bit 2 in
>>> word 82 of the identify data instead the word 83; it also checks the
>>> ATA/PI
>>> version support in the word 80 (which the CompactFlash specifications
>>> have as
>>> reserved), this having no slightest chance to work on the modern CF
>>> cards that
>>> don't have 0x848A in the word 0...
>>> Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
>> Acked-by: Alan Cox <number6@the-village.bc.nu>
> I'll send it upstream, thanks all!
Hold up please, Mark gave us an example that it doesnt recognize because
it does report the ATA version in word 80.
MBR, Sergei
next prev parent reply other threads:[~2009-01-27 16:08 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-27 13:19 [PATCH] ide/libata: fix ata_id_is_cfa() (take 3) Sergei Shtylyov
2009-01-27 13:38 ` Alan Cox
2009-01-27 13:49 ` Jeff Garzik
2009-01-27 16:09 ` Sergei Shtylyov [this message]
2009-01-27 16:21 ` Sergei Shtylyov
2009-01-27 15:56 ` Mark Lord
2009-01-27 16:16 ` Sergei Shtylyov
2009-01-27 16:18 ` Mark Lord
2009-01-27 16:26 ` Sergei Shtylyov
2009-01-27 16:28 ` Mark Lord
2009-01-28 7:51 ` Dmitry Gryazin
2009-01-28 15:03 ` ide/libata: fix ata_id_is_cfa() .. hdparm-9.10 Mark Lord
2009-01-27 17:41 ` [PATCH] ide/libata: fix ata_id_is_cfa() (take 3) Mark Lord
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=497F31A0.7010104@ru.mvista.com \
--to=sshtylyov@ru.mvista.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=bzolnier@gmail.com \
--cc=gdu@mns.spb.ru \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).