From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [PATCH] ide/libata: fix ata_id_is_cfa() (take 3) Date: Tue, 27 Jan 2009 19:09:04 +0300 Message-ID: <497F31A0.7010104@ru.mvista.com> References: <200901271619.53025.sshtylyov@ru.mvista.com> <20090127133841.2405e649@lxorguk.ukuu.org.uk> <497F10D1.5020400@pobox.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from h155.mvista.com ([63.81.120.155]:34320 "EHLO imap.sh.mvista.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1751865AbZA0QIe (ORCPT ); Tue, 27 Jan 2009 11:08:34 -0500 In-Reply-To: <497F10D1.5020400@pobox.com> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Jeff Garzik Cc: Alan Cox , bzolnier@gmail.com, linux-ide@vger.kernel.org, gdu@mns.spb.ru Jeff Garzik wrote: >>> When checking for the CFA feature set support, ata_id_is_cfa() tests >>> bit 2 in >>> word 82 of the identify data instead the word 83; it also checks the >>> ATA/PI >>> version support in the word 80 (which the CompactFlash specifications >>> have as >>> reserved), this having no slightest chance to work on the modern CF >>> cards that >>> don't have 0x848A in the word 0... >>> Signed-off-by: Sergei Shtylyov >> Acked-by: Alan Cox > I'll send it upstream, thanks all! Hold up please, Mark gave us an example that it doesnt recognize because it does report the ATA version in word 80. MBR, Sergei