From: "Sachin P. Sant" <sachinp@in.ibm.com>
To: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Cc: jgarzik@pobox.com, linux-ide@vger.kernel.org
Subject: [BUILD_FAILURE] 2.6.29-rc3 : drivers/ata/sata_sil.c
Date: Thu, 29 Jan 2009 14:58:22 +0530 [thread overview]
Message-ID: <498176B6.1040404@in.ibm.com> (raw)
In-Reply-To: <alpine.LFD.2.00.0901281120460.3123@localhost.localdomain>
[-- Attachment #1: Type: text/plain, Size: 859 bytes --]
2.6.29-rc3 with allmodconfig breaks with following message
CALL arch/powerpc/kernel/systbl_chk.sh
CALL arch/powerpc/kernel/prom_init_check.sh
LD [M] drivers/ata/libata.o
CC [M] drivers/ata/sata_sil.o
drivers/ata/sata_sil.c: In function sil_broken_system_poweroff:
drivers/ata/sata_sil.c:713: error: implicit declaration of function dmi_first_match
drivers/ata/sata_sil.c:713: warning: initialization makes pointer from integer without a cast
make[2]: *** [drivers/ata/sata_sil.o] Error 1
make[1]: *** [drivers/ata] Error 2
make: *** [drivers] Error 2
Probably needs to include <linux/dmi.h>. The following patch fixes it.
Signed-off-by : Sachin Sant <sachinp@in.ibm.com>
---
--
---------------------------------
Sachin Sant
IBM Linux Technology Center
India Systems and Technology Labs
Bangalore, India
---------------------------------
[-- Attachment #2: fix-ata-build-break.patch --]
[-- Type: text/x-patch, Size: 486 bytes --]
* Fix ata build break (undefined dmi_first_match symbol)
Signed-off-by : Sachin Sant<sachinp@in.ibm.com>
---
diff -Naurp a/drivers/ata/sata_sil.c b/drivers/ata/sata_sil.c
--- a/drivers/ata/sata_sil.c 2009-01-29 00:19:30.000000000 +0530
+++ b/drivers/ata/sata_sil.c 2009-01-29 17:15:03.000000000 +0530
@@ -44,6 +44,7 @@
#include <linux/device.h>
#include <scsi/scsi_host.h>
#include <linux/libata.h>
+#include <linux/dmi.h>
#define DRV_NAME "sata_sil"
#define DRV_VERSION "2.4"
parent reply other threads:[~2009-01-29 9:28 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <alpine.LFD.2.00.0901281120460.3123@localhost.localdomain>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=498176B6.1040404@in.ibm.com \
--to=sachinp@in.ibm.com \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).