From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
To: Kevin Hilman <khilman@deeprootsystems.com>
Cc: linux-ide@vger.kernel.org,
davinci-linux-open-source@linux.davincidsp.com
Subject: Re: [PATCH] IDE: palm_bk3710: use ioremap instead of arch-specific IO_ADDRESS()
Date: Fri, 30 Jan 2009 02:51:07 +0300 [thread overview]
Message-ID: <498240EB.3090907@ru.mvista.com> (raw)
In-Reply-To: <1233270357-604-1-git-send-email-khilman@deeprootsystems.com>
Hello.
Kevin Hilman wrote:
> Signed-off-by: Kevin Hilman <khilman@deeprootsystems.com>
>
Sorry, NAK.
> diff --git a/drivers/ide/palm_bk3710.c b/drivers/ide/palm_bk3710.c
> index f38aac7..be9c904 100644
> --- a/drivers/ide/palm_bk3710.c
> +++ b/drivers/ide/palm_bk3710.c
> @@ -380,7 +380,11 @@ static int __init palm_bk3710_probe(struct platform_device *pdev)
> return -EBUSY;
> }
>
> - base = IO_ADDRESS(mem->start);
> + base = ioremap(mem->start, mem->end);
> + if (!base) {
> + printk(KERN_ERR "failed to map IO memory\n");
> + return -ENOMEM;
>
Leaks requested memory region.
MBR, Sergei
next prev parent reply other threads:[~2009-01-29 23:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-29 23:05 [PATCH] IDE: palm_bk3710: use ioremap instead of arch-specific IO_ADDRESS() Kevin Hilman
2009-01-29 23:51 ` Sergei Shtylyov [this message]
2009-01-30 0:29 ` Kevin Hilman
2009-01-30 11:43 ` Sergei Shtylyov
2009-01-30 18:23 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=498240EB.3090907@ru.mvista.com \
--to=sshtylyov@ru.mvista.com \
--cc=davinci-linux-open-source@linux.davincidsp.com \
--cc=khilman@deeprootsystems.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).