* [PATCH] IDE: palm_bk3710: use ioremap instead of arch-specific IO_ADDRESS()
@ 2009-01-29 23:05 Kevin Hilman
2009-01-29 23:51 ` Sergei Shtylyov
0 siblings, 1 reply; 5+ messages in thread
From: Kevin Hilman @ 2009-01-29 23:05 UTC (permalink / raw)
To: linux-ide; +Cc: davinci-linux-open-source, Sergei Shtylyov
Cc: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Signed-off-by: Kevin Hilman <khilman@deeprootsystems.com>
---
drivers/ide/palm_bk3710.c | 6 +++++-
1 files changed, 5 insertions(+), 1 deletions(-)
diff --git a/drivers/ide/palm_bk3710.c b/drivers/ide/palm_bk3710.c
index f38aac7..be9c904 100644
--- a/drivers/ide/palm_bk3710.c
+++ b/drivers/ide/palm_bk3710.c
@@ -380,7 +380,11 @@ static int __init palm_bk3710_probe(struct platform_device *pdev)
return -EBUSY;
}
- base = IO_ADDRESS(mem->start);
+ base = ioremap(mem->start, mem->end);
+ if (!base) {
+ printk(KERN_ERR "failed to map IO memory\n");
+ return -ENOMEM;
+ }
/* Configure the Palm Chip controller */
palm_bk3710_chipinit(base);
--
1.6.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] IDE: palm_bk3710: use ioremap instead of arch-specific IO_ADDRESS()
2009-01-29 23:05 [PATCH] IDE: palm_bk3710: use ioremap instead of arch-specific IO_ADDRESS() Kevin Hilman
@ 2009-01-29 23:51 ` Sergei Shtylyov
2009-01-30 0:29 ` Kevin Hilman
0 siblings, 1 reply; 5+ messages in thread
From: Sergei Shtylyov @ 2009-01-29 23:51 UTC (permalink / raw)
To: Kevin Hilman; +Cc: linux-ide, davinci-linux-open-source
Hello.
Kevin Hilman wrote:
> Signed-off-by: Kevin Hilman <khilman@deeprootsystems.com>
>
Sorry, NAK.
> diff --git a/drivers/ide/palm_bk3710.c b/drivers/ide/palm_bk3710.c
> index f38aac7..be9c904 100644
> --- a/drivers/ide/palm_bk3710.c
> +++ b/drivers/ide/palm_bk3710.c
> @@ -380,7 +380,11 @@ static int __init palm_bk3710_probe(struct platform_device *pdev)
> return -EBUSY;
> }
>
> - base = IO_ADDRESS(mem->start);
> + base = ioremap(mem->start, mem->end);
> + if (!base) {
> + printk(KERN_ERR "failed to map IO memory\n");
> + return -ENOMEM;
>
Leaks requested memory region.
MBR, Sergei
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] IDE: palm_bk3710: use ioremap instead of arch-specific IO_ADDRESS()
2009-01-29 23:51 ` Sergei Shtylyov
@ 2009-01-30 0:29 ` Kevin Hilman
2009-01-30 11:43 ` Sergei Shtylyov
0 siblings, 1 reply; 5+ messages in thread
From: Kevin Hilman @ 2009-01-30 0:29 UTC (permalink / raw)
To: Sergei Shtylyov; +Cc: linux-ide, davinci-linux-open-source
Sergei Shtylyov <sshtylyov@ru.mvista.com> writes:
> Hello.
>
> Kevin Hilman wrote:
>
>> Signed-off-by: Kevin Hilman <khilman@deeprootsystems.com>
>>
>
> Sorry, NAK.
>
>> diff --git a/drivers/ide/palm_bk3710.c b/drivers/ide/palm_bk3710.c
>> index f38aac7..be9c904 100644
>> --- a/drivers/ide/palm_bk3710.c
>> +++ b/drivers/ide/palm_bk3710.c
>> @@ -380,7 +380,11 @@ static int __init palm_bk3710_probe(struct platform_device *pdev)
>> return -EBUSY;
>> }
>> - base = IO_ADDRESS(mem->start);
>> + base = ioremap(mem->start, mem->end);
>> + if (!base) {
>> + printk(KERN_ERR "failed to map IO memory\n");
>> + return -ENOMEM;
>>
>
> Leaks requested memory region.
>
Where would you suggest putting the iounmap? If the driver had a
remove hook, I would've put it there.
Which brings up a bigger question, why isn't there a remove hook. I
vaguely remember there being some problem way back in the 2.6.18 time
frame that wouldn't allow this driver to be removed. Is that still a
problem in newer kernels?
Kevin
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] IDE: palm_bk3710: use ioremap instead of arch-specific IO_ADDRESS()
2009-01-30 0:29 ` Kevin Hilman
@ 2009-01-30 11:43 ` Sergei Shtylyov
2009-01-30 18:23 ` Kevin Hilman
0 siblings, 1 reply; 5+ messages in thread
From: Sergei Shtylyov @ 2009-01-30 11:43 UTC (permalink / raw)
To: Kevin Hilman; +Cc: linux-ide, davinci-linux-open-source
Hello.
Kevin Hilman wrote:
>> Hello.
>>
>> Kevin Hilman wrote:
>>
>>
>>> Signed-off-by: Kevin Hilman <khilman@deeprootsystems.com>
>>>
>>>
>> Sorry, NAK.
>>
>>
>>> diff --git a/drivers/ide/palm_bk3710.c b/drivers/ide/palm_bk3710.c
>>> index f38aac7..be9c904 100644
>>> --- a/drivers/ide/palm_bk3710.c
>>> +++ b/drivers/ide/palm_bk3710.c
>>> @@ -380,7 +380,11 @@ static int __init palm_bk3710_probe(struct platform_device *pdev)
>>> return -EBUSY;
>>> }
>>> - base = IO_ADDRESS(mem->start);
>>> + base = ioremap(mem->start, mem->end);
>>> + if (!base) {
>>> + printk(KERN_ERR "failed to map IO memory\n");
>>> + return -ENOMEM;
>>>
>>>
>> Leaks requested memory region.
> Where would you suggest putting the iounmap?
You misunderstood -- you don't call release_mem_region() on the error
path.
> Which brings up a bigger question, why isn't there a remove hook. I
> vaguely remember there being some problem way back in the 2.6.18 time
> frame that wouldn't allow this driver to be removed.
The IDE drivers were generally undremovable back then.
> Is that still a problem in newer kernels?
>
No, shouldn't be -- they've been made removable since.
> Kevin
MBR, Sergei
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] IDE: palm_bk3710: use ioremap instead of arch-specific IO_ADDRESS()
2009-01-30 11:43 ` Sergei Shtylyov
@ 2009-01-30 18:23 ` Kevin Hilman
0 siblings, 0 replies; 5+ messages in thread
From: Kevin Hilman @ 2009-01-30 18:23 UTC (permalink / raw)
To: Sergei Shtylyov; +Cc: linux-ide, davinci-linux-open-source
Sergei Shtylyov <sshtylyov@ru.mvista.com> writes:
> Hello.
>
> Kevin Hilman wrote:
>
>>> Hello.
>>>
>>> Kevin Hilman wrote:
>>>
>>>
>>>> Signed-off-by: Kevin Hilman <khilman@deeprootsystems.com>
>>>>
>>> Sorry, NAK.
>>>
>>>
>>>> diff --git a/drivers/ide/palm_bk3710.c b/drivers/ide/palm_bk3710.c
>>>> index f38aac7..be9c904 100644
>>>> --- a/drivers/ide/palm_bk3710.c
>>>> +++ b/drivers/ide/palm_bk3710.c
>>>> @@ -380,7 +380,11 @@ static int __init palm_bk3710_probe(struct platform_device *pdev)
>>>> return -EBUSY;
>>>> }
>>>> - base = IO_ADDRESS(mem->start);
>>>> + base = ioremap(mem->start, mem->end);
>>>> + if (!base) {
>>>> + printk(KERN_ERR "failed to map IO memory\n");
>>>> + return -ENOMEM;
>>>>
>>> Leaks requested memory region.
>> Where would you suggest putting the iounmap?
>
> You misunderstood -- you don't call release_mem_region() on the
> error path.
Ah, I see. Good catch. I also noticed ioremap() takes 'size' and not
'end' so that needs to be fixed too. Will resend.
Kevin
>> Which brings up a bigger question, why isn't there a remove hook. I
>> vaguely remember there being some problem way back in the 2.6.18 time
>> frame that wouldn't allow this driver to be removed.
>
> The IDE drivers were generally undremovable back then.
>
>> Is that still a problem in newer kernels?
>>
>
> No, shouldn't be -- they've been made removable since.
>
>> Kevin
>
> MBR, Sergei
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2009-01-30 18:23 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-01-29 23:05 [PATCH] IDE: palm_bk3710: use ioremap instead of arch-specific IO_ADDRESS() Kevin Hilman
2009-01-29 23:51 ` Sergei Shtylyov
2009-01-30 0:29 ` Kevin Hilman
2009-01-30 11:43 ` Sergei Shtylyov
2009-01-30 18:23 ` Kevin Hilman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).