From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
To: Kevin Hilman <khilman@deeprootsystems.com>
Cc: linux-ide@vger.kernel.org,
davinci-linux-open-source@linux.davincidsp.com
Subject: Re: [PATCH v2] IDE: palm_bk3710: use ioremap instead of arch-specific IO_ADDRESS()
Date: Fri, 30 Jan 2009 23:03:47 +0300 [thread overview]
Message-ID: <49835D23.5040604@ru.mvista.com> (raw)
In-Reply-To: <1233345567-643-1-git-send-email-khilman@deeprootsystems.com>
Kevin Hilman wrote:
> Signed-off-by: Kevin Hilman <khilman@deeprootsystems.com>
Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
> diff --git a/drivers/ide/palm_bk3710.c b/drivers/ide/palm_bk3710.c
> index f38aac7..6196f76 100644
> --- a/drivers/ide/palm_bk3710.c
> +++ b/drivers/ide/palm_bk3710.c
> @@ -347,7 +347,7 @@ static int __init palm_bk3710_probe(struct platform_device *pdev)
> struct clk *clk;
> struct resource *mem, *irq;
> void __iomem *base;
> - unsigned long rate;
> + unsigned long rate, mem_size;
> int i, rc;
> hw_regs_t hw, *hws[] = { &hw, NULL, NULL, NULL };
>
> @@ -374,13 +374,19 @@ static int __init palm_bk3710_probe(struct platform_device *pdev)
> return -ENODEV;
> }
>
> - if (request_mem_region(mem->start, mem->end - mem->start + 1,
> + mem_size = mem->end - mem->start + 1;
> + if (request_mem_region(mem->start, mem_size,
> "palm_bk3710") == NULL) {
No point in keeping *if* occupying 2 lines, I think...
MBR, Sergei
next prev parent reply other threads:[~2009-01-30 20:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-30 19:59 [PATCH v2] IDE: palm_bk3710: use ioremap instead of arch-specific IO_ADDRESS() Kevin Hilman
2009-01-30 20:03 ` Sergei Shtylyov [this message]
2009-02-01 16:03 ` Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49835D23.5040604@ru.mvista.com \
--to=sshtylyov@ru.mvista.com \
--cc=davinci-linux-open-source@linux.davincidsp.com \
--cc=khilman@deeprootsystems.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).