From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tejun Heo Subject: Re: [PATCH #upstream-fixes 1/2] pata_atiixp: update port enabledness test handling Date: Sun, 01 Feb 2009 10:32:09 +0900 Message-ID: <4984FB99.6000704@kernel.org> References: <497028CF.7030408@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Return-path: Received: from hera.kernel.org ([140.211.167.34]:33772 "EHLO hera.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752546AbZBABcY (ORCPT ); Sat, 31 Jan 2009 20:32:24 -0500 In-Reply-To: <497028CF.7030408@kernel.org> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Jeff Garzik , IDE/ATA development list , bugsbuggy@ymail.com Tejun Heo wrote: > Port enabledness test fits much better into init_one() instead of > pre_reset(). The reason why these tests are in pre_reset() is purely > historical at this point. Move it to init_one(). This will help > further changes. > > Signed-off-by: Tejun Heo Jeff, the second one turned out to be unnecessary but this patch is worthy on its own. Can you please put it into #upstream? Thanks. -- tejun