From: Tejun Heo <tj@kernel.org>
To: Jeff Garzik <jeff@garzik.org>,
IDE/ATA development list <linux-ide@vger.kernel.org>,
Mark Lord <liml@rtr.ca>
Subject: Re: [PATCH #upstream] ahci/sata_vsc: drop intx manipulation on msi enable
Date: Sun, 01 Feb 2009 10:32:30 +0900 [thread overview]
Message-ID: <4984FBAE.1090709@kernel.org> (raw)
In-Reply-To: <49792C0B.6070602@kernel.org>
Tejun Heo wrote:
> There's no need to turn off intx explicitly on msi enable. This is
> automatically handled by pci. Drop it.
>
> Note that, in sata_vsc's case, it was completely redundant; however,
> for ahci, it might be needed on machines if the BIOS turns intx off
> during boot. However, there's no evidence of such behavior for ahci
> and the only such case seems to be ICH5 PATA according to ata_piix.
> Also, given the way ahci operates, it's highly unlikely BIOS ever
> disables IRQ for the controller. However, as this change has slight
> possibility of introducing failure, please schedule it for #upstream.
>
> Signed-off-by: Tejun Heo <tj@kernel.org>
Ping.
--
tejun
next prev parent reply other threads:[~2009-02-01 1:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-23 2:31 [PATCH #upstream] ahci/sata_vsc: drop intx manipulation on msi enable Tejun Heo
2009-02-01 1:32 ` Tejun Heo [this message]
2009-02-17 0:10 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4984FBAE.1090709@kernel.org \
--to=tj@kernel.org \
--cc=jeff@garzik.org \
--cc=liml@rtr.ca \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).