From: Tejun Heo <tj@kernel.org>
To: Jeff Garzik <jeff@garzik.org>
Cc: linux-scsi@vger.kernel.org, jens.axboe@oracle.com,
linux-kernel@vger.kernel.org,
James.Bottomley@HansenPartnership.com, linux-ide@vger.kernel.org,
dm-devel@redhat.com, Mauelshagen@redhat.com
Subject: Re: [PATCHSET] block,scsi,libata: implement alt_size
Date: Sun, 01 Feb 2009 13:14:48 +0900 [thread overview]
Message-ID: <498521B8.1020703@kernel.org> (raw)
In-Reply-To: <49851507.5040905@garzik.org>
Hello, Jeff.
Jeff Garzik wrote:
> But the net result is that you are telling dmraid that it is OK to
> proceed, even though part of the disk it wants is really missing. That
> seems unwise, because are you not basically proceeding with a known
> corrupt dataset at that point?
Can you elaborate a bit? I don't really understand what you mean. To
clarify...
* What happens now.
BIOS sets up HPA expecting the raid driver to look at the metadata
which is at fixed offset from the end of the HPA locked size. dmraid
doesn't know about it so looks at the wrong place. Results can be
failed assembly or corrupt assembly depending on what's actually on
the disk.
* With the patches applied.
BIOS does the same but libata tells dmraid the BIOS size. dmraid
looks at the same offset as the BIOS and everything is well.
Thanks.
--
tejun
next prev parent reply other threads:[~2009-02-01 4:14 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-01 2:55 [PATCHSET] block,scsi,libata: implement alt_size Tejun Heo
2009-02-01 2:55 ` [PATCH 1/3] block: add alt_size Tejun Heo
2009-02-01 2:55 ` [PATCH 2/3] scsi: add scsi_device->alt_capacity Tejun Heo
2009-02-01 2:55 ` [PATCH 3/3] libata: export HPA size as alt_size Tejun Heo
2009-02-02 17:12 ` [PATCH] libata: change drive ready wait after hard reset to 5s Stuart_Hayes
2009-02-02 17:17 ` Mario Limonciello
2009-02-09 21:48 ` Stuart_Hayes
2009-02-01 2:59 ` [PATCHSET] dmraid: use alt_size Tejun Heo
2009-02-01 3:00 ` [PATCH 1/3] dmraid: set read_info to @offset by default in read_raid_dev() Tejun Heo
2009-02-01 3:00 ` [PATCH 2/3] dmraid: add alt_size to dev_info Tejun Heo
2009-02-01 3:01 ` [PATCH 3/3] dmraid: make nv use alt_size if available Tejun Heo
2009-02-01 3:20 ` [PATCHSET] block,scsi,libata: implement alt_size Jeff Garzik
2009-02-01 4:14 ` Tejun Heo [this message]
2009-04-30 1:13 ` Tejun Heo
2009-04-30 1:45 ` Jeff Garzik
2009-04-30 1:50 ` Tejun Heo
2009-04-30 20:00 ` Jeff Garzik
2009-04-30 21:15 ` Dan Williams
2009-05-04 8:02 ` Tejun Heo
2009-05-04 16:48 ` Dan Williams
2009-05-05 3:28 ` Tejun Heo
2009-05-05 15:34 ` Dan Williams
2009-05-08 9:13 ` Tejun Heo
2009-05-08 16:21 ` Jeff Garzik
2009-05-08 16:23 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=498521B8.1020703@kernel.org \
--to=tj@kernel.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=Mauelshagen@redhat.com \
--cc=dm-devel@redhat.com \
--cc=jeff@garzik.org \
--cc=jens.axboe@oracle.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).