From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
To: Hugh Dickins <hugh@veritas.com>
Cc: jgarzik@pobox.com, linux-ide@vger.kernel.org,
linux-kernel@vger.kernel.org, alan@lxorguk.ukuu.org.uk,
rjw@sisk.pl
Subject: Re: [PATCH] libata-sff: fix 32-bit PIO regression
Date: Mon, 09 Feb 2009 03:07:01 +0300 [thread overview]
Message-ID: <498F73A5.2070300@ru.mvista.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0902082108290.18661@blonde.anvils>
Hello.
Hugh Dickins wrote:
>> Commit 871af1210f13966ab911ed2166e4ab2ce775b99d (libata: Add 32bit PIO support)
>> caused all kind of errors on the ATAPI devices, so it's been empirically proven
>> that one shouldn't read/write an extra data word when a device isn't expecting
>> it already. "Don't do it then"; however still taking a chance to use 32-bit I/O
>> one last time when there are exactly 3 trailing bytes. Oh, and stop pointless
>> swapping bytes to and fro as well by using io*_rep() which shouldn't byte-swap.
>>
>> This should fix the kernel.org bug #12609.
>>
>> ---
>> This is hopefully better replacement for Hugh Dickins most recent patch
>> (http://marc.info/?l=linux-ide&m=123352294619281)...
>>
>
> Yes, looks nice, and works for me. My only criticism would be,
> minor issue unchanged by your patch, that actually "slop" isn't
> unlikely enough to deserve an "unlikely" - slop of 1 or 3 is
> unlikely, but slop of 2 is quite common.
>
Common on what types of ATAPI commands? I can hardly believe that they
are common on the block I/O...
MBR, Sergei
next prev parent reply other threads:[~2009-02-09 0:07 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-08 19:53 [PATCH] libata-sff: fix 32-bit PIO regression Sergei Shtylyov
2009-02-08 20:11 ` Alan Cox
2009-02-08 22:10 ` Sergei Shtylyov
2009-02-08 21:12 ` Hugh Dickins
2009-02-08 22:18 ` Sergei Shtylyov
2009-02-08 23:48 ` Mikael Pettersson
2009-02-09 0:03 ` Sergei Shtylyov
2009-02-09 0:19 ` Jeff Garzik
2009-02-09 10:43 ` Sergei Shtylyov
2009-02-09 10:56 ` Sergei Shtylyov
2009-02-09 0:07 ` Sergei Shtylyov [this message]
2009-02-09 10:22 ` Hugh Dickins
2009-02-09 16:42 ` Sergei Shtylyov
2009-02-09 16:48 ` Sergei Shtylyov
2009-02-09 18:14 ` Hugh Dickins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=498F73A5.2070300@ru.mvista.com \
--to=sshtylyov@ru.mvista.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=hugh@veritas.com \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).