From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
To: Stanislaw Gruszka <stf_xl@wp.pl>
Cc: linux-ide@vger.kernel.org, Andrew Victor <avictor.za@gmail.com>,
linux-arm-kernel@lists.arm.linux.org.uk
Subject: Re: [PATCH 3/3 v3] AT91: initialize Compact Flash on AT91SAM9263 cpu
Date: Wed, 11 Feb 2009 16:59:00 +0300 [thread overview]
Message-ID: <4992D9A4.30205@ru.mvista.com> (raw)
In-Reply-To: <200902091145.11266.stf_xl@wp.pl>
Hello.
Stanislaw Gruszka wrote:
> Signed-off-by: Stanislaw Gruszka <stf_xl@wp.pl>
>
Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
> index b753cb8..8e46abe 100644
> --- a/arch/arm/mach-at91/at91sam9263_devices.c
> +++ b/arch/arm/mach-at91/at91sam9263_devices.c
>
[...]
> +void __init at91_add_device_cf(struct at91_cf_data *data)
> +{
> + unsigned long ebi0_csa, addr_space;
>
[...]
> + if (data->flags & AT91_CF_TRUE_IDE) {
> + /* check if device is present */
> + if (data->det_pin && at91_get_gpio_value(data->det_pin) != 0) {
> + printk(KERN_ERR "AT91 CF True IDE: no device detected\n");
> + return;
> + }
> + if (data->rst_pin) {
> + /* reset the card */
> + at91_set_gpio_output(data->rst_pin, 0);
> + /* wait as defined in ATA7 vol2 (rev 4a) figure 36 */
> + udelay(25);
> + at91_set_gpio_output(data->rst_pin, 1);
>
I'm still not sure why this is needed. Do you think thta power-on
reset is not enough?
MBR, Sergei
next prev parent reply other threads:[~2009-02-11 13:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-09 10:45 [PATCH 3/3 v3] AT91: initialize Compact Flash on AT91SAM9263 cpu Stanislaw Gruszka
2009-02-11 13:59 ` Sergei Shtylyov [this message]
2009-02-11 16:46 ` Bartlomiej Zolnierkiewicz
2009-02-11 17:31 ` Sergei Shtylyov
2009-02-12 9:05 ` Stanislaw Gruszka
2009-02-12 16:33 ` Sergei Shtylyov
2009-02-13 10:48 ` Stanislaw Gruszka
2009-02-11 20:03 ` Andrew Victor
2009-02-12 9:33 ` Stanislaw Gruszka
2009-02-13 13:23 ` Sergei Shtylyov
2009-02-17 10:21 ` Stanislaw Gruszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4992D9A4.30205@ru.mvista.com \
--to=sshtylyov@ru.mvista.com \
--cc=avictor.za@gmail.com \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
--cc=linux-ide@vger.kernel.org \
--cc=stf_xl@wp.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).