From: Robert Hancock <hancockrwd@gmail.com>
To: Jeff Garzik <jeff@garzik.org>
Cc: akpm@linux-foundation.org, linux-ide@vger.kernel.org,
alan@lxorguk.ukuu.org.uk
Subject: Re: [patch for 2.6.29? 2/4] pata_amd: program FIFO
Date: Wed, 11 Feb 2009 22:10:10 -0600 [thread overview]
Message-ID: <4993A122.7040807@gmail.com> (raw)
In-Reply-To: <49933FAE.1090006@garzik.org>
Jeff Garzik wrote:
> akpm@linux-foundation.org wrote:
>> From: Alan Cox <alan@lxorguk.ukuu.org.uk>
>>
>> With 32bit PIO we can use the posted write buffers, but only for 32bit
>> I/O
>> cycles. This means we must disable the FIFO for ATAPI where a final
>> 16bit
>> cycle may occur.
>>
>> Rework the FIFO logic so that we disable the FIFO then selectively
>> re-enable it when we set the timings on AMD devices. Also fix a case
>> where we scribbled on PCI config 0x41 of Nvidia chips when we shouldn't.
>>
>> Signed-off-by: Alan Cox <alan@lxorguk.ukuu.org.uk>
>> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
>
> Pinged Alan on 2/2, no response.
>
> This seems necessary... but too instrusive and not yet well tested
> enough for 2.6.29-rc?
I think we either need this patch or turn 32-bit PIO off for this driver
for 2.6.29. Without either, things may break.
next prev parent reply other threads:[~2009-02-12 4:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-11 21:08 [patch for 2.6.29? 2/4] pata_amd: program FIFO akpm
2009-02-11 21:14 ` Jeff Garzik
2009-02-12 4:10 ` Robert Hancock [this message]
2009-02-25 20:31 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4993A122.7040807@gmail.com \
--to=hancockrwd@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).