From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [PATCH 14/18] ide: use ->tf_read in ide_read_error() Date: Mon, 16 Feb 2009 15:25:40 +0300 Message-ID: <49995B44.6090604@ru.mvista.com> References: <20080620213323.13202.71450.sendpatchset@localhost.localdomain> <20080620213458.13202.77992.sendpatchset@localhost.localdomain> <4998A37D.3040904@ru.mvista.com> <49995856.0@ru.mvista.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from homer.mvista.com ([63.81.120.155]:58430 "EHLO imap.sh.mvista.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1752919AbZBPMZp (ORCPT ); Mon, 16 Feb 2009 07:25:45 -0500 In-Reply-To: <49995856.0@ru.mvista.com> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Bartlomiej Zolnierkiewicz Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org Hello, I wrote: >>> register and handle it in ->tf_read. >>> >> >> Doesn't seem like a good name -- you can't read the features >> register. I should've commented to this patch earlier, of course... > * Add IDE_TFLAG_IN_FEATURE taskfile flag for reading Feature > > Moreover, the error register shoudn't be affeceted by the HOB bit, > so this flag doesn't make sense. I meant IDE_TFLAG_IN_HOB_FEATURE, of course. MBR, Sergei