From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [PATCH 14/18] ide: use ->tf_read in ide_read_error() Date: Tue, 17 Feb 2009 03:50:27 +0300 Message-ID: <499A09D3.8070303@ru.mvista.com> References: <20080620213323.13202.71450.sendpatchset@localhost.localdomain> <49995856.0@ru.mvista.com> <49995B44.6090604@ru.mvista.com> <200902162217.08541.bzolnier@gmail.com> <499A0181.8000008@ru.mvista.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from h155.mvista.com ([63.81.120.155]:4375 "EHLO imap.sh.mvista.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1751170AbZBQAud (ORCPT ); Mon, 16 Feb 2009 19:50:33 -0500 In-Reply-To: <499A0181.8000008@ru.mvista.com> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Bartlomiej Zolnierkiewicz Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org Hello, I wrote: >>>> >>> I meant IDE_TFLAG_IN_HOB_FEATURE, of course. >>> >> >> Once again blame the certain ioctl (you know which one)... :) >> > Moreover, the error register shoudn't be affeceted by the HOB bit, > so this flag doesn't make sense. > > Oh, horror... and I know that it wasn't completely ungrounded since > both ATA/PI-6 adn -7 have words about reading the features register > (depending on HOB). At least ATA/PI-8 got rid of this. Anyway, I think > we can safely get rid of this flag and just return the same value in > 'features' and 'hob_features'. Although, after thinking a bit more, it doesn't seem worth the trouble -- so the rename should suffice... MBR, Sergei