From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [PATCH] ide-cd: document capacity hack Date: Wed, 18 Feb 2009 22:35:27 +0300 Message-ID: <499C62FF.1090805@ru.mvista.com> References: <200902182018.52195.bzolnier@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from gateway-1237.mvista.com ([63.81.120.155]:62973 "EHLO imap.sh.mvista.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1754911AbZBRTfH (ORCPT ); Wed, 18 Feb 2009 14:35:07 -0500 In-Reply-To: <200902182018.52195.bzolnier@gmail.com> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Bartlomiej Zolnierkiewicz Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org, Borislav Petkov Hello. Bartlomiej Zolnierkiewicz wrote: > Just copy the comment from drivers/scsi/sr.c::sr_done() > (from which the capacity hack has been originated). > Cc: Borislav Petkov > Signed-off-by: Bartlomiej Zolnierkiewicz Acked-by: Sergei Shtylyov > Index: b/drivers/ide/ide-cd.c > =================================================================== > --- a/drivers/ide/ide-cd.c > +++ b/drivers/ide/ide-cd.c > @@ -189,6 +189,14 @@ static void cdrom_analyze_sense_data(ide > bio_sectors = max(bio_sectors(failed_command->bio), 4U); > sector &= ~(bio_sectors - 1); > > + /* > + * The SCSI specification allows for the value > + * returned by READ CAPACITY to be up to 75 2K > + * sectors past the last readable block. Oh horror... :-) > + * Therefore, if we hit a medium error within the > + * last 75 2K sectors, we decrease the saved size > + * value. > + */ > if (sector < get_capacity(info->disk) && > drive->probed_capacity - sector < 4 * 75) > set_capacity(info->disk, sector); Would be nice if the CHS capacity workround was finally documented too? ;-) MBR, Sergei