From: Mark Lord <liml@rtr.ca>
To: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: Michael Tokarev <mjt@tls.msk.ru>, linux-ide@vger.kernel.org
Subject: Re: [PATCH] hdparm: Show form factor and media rotation rate
Date: Mon, 23 Feb 2009 15:26:30 -0500 [thread overview]
Message-ID: <49A30676.4090906@rtr.ca> (raw)
In-Reply-To: <yq11vtpuo4t.fsf@sermon.lab.mkp.net>
Martin K. Petersen wrote:
>>>>>> "Michael" == Michael Tokarev <mjt@tls.msk.ru> writes:
>
> Michael> How about printing the actual (unrecognized) value here? Like
> Michael> this:
>
> Michael> + default:
> Michael> + printf("unknown (raw value = %d)", val[FORM_FACTOR]);
> Michael> + break;
>
> I'm ok with that. Mark?
..
Already done, except in hex.
Cheers
next prev parent reply other threads:[~2009-02-23 20:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-21 1:01 [PATCH] hdparm: Show form factor and media rotation rate Martin K. Petersen
2009-02-21 22:41 ` Michael Tokarev
2009-02-23 16:14 ` Martin K. Petersen
2009-02-23 20:26 ` Mark Lord [this message]
2009-02-22 5:53 ` Mark Lord
2009-02-23 16:13 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49A30676.4090906@rtr.ca \
--to=liml@rtr.ca \
--cc=linux-ide@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=mjt@tls.msk.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox