From: Jeff Garzik <jeff@garzik.org>
To: akpm@linux-foundation.org
Cc: linux-ide@vger.kernel.org, linux@rainbow-software.org,
alan@lxorguk.ukuu.org.uk
Subject: Re: [patch for 2.6.29? 4/4] pata_it821x: resume from hibernation fails with RAID volume
Date: Wed, 25 Feb 2009 15:29:04 -0500 [thread overview]
Message-ID: <49A5AA10.5020800@garzik.org> (raw)
In-Reply-To: <200902112108.n1BL8hk7005336@imap1.linux-foundation.org>
akpm@linux-foundation.org wrote:
> From: Ondrej Zary <linux@rainbow-software.org>
>
> Hibernation didn't work for me since I started to use IT8212 controller.
> I did some debugging (booting with no_console_suspend init=/bin/sh).
>
> Found that resume fails (2.6.28) with "serial number mismatch 'some
> garbage' != 'some other garbage'" and "revalidation failed" messages.
> That's because the controller firmware fills different serial number in
> the IDENTIFY every boot.
>
> The patch below fixes the resume simply clearing the serial number. The
> proper fix would be probably to fill in the serial number of the RAID
> volume instead. I assume that there must be something like that stored on
> the drives but I don't know where.
>
> Fix resume on pata_it821x RAID volume by clearing the serial number in
> IDENTIFY data, which is otherwise different on each boot.
>
> Signed-off-by: Ondrej Zary <linux@rainbow-software.org>
> Acked-by: Alan Cox <alan@lxorguk.ukuu.org.uk>
> Cc: Jeff Garzik <jeff@garzik.org>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> ---
>
> drivers/ata/pata_it821x.c | 3 +++
> 1 file changed, 3 insertions(+)
>
applied
prev parent reply other threads:[~2009-02-25 20:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-11 21:08 [patch for 2.6.29? 4/4] pata_it821x: resume from hibernation fails with RAID volume akpm
2009-02-25 20:29 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49A5AA10.5020800@garzik.org \
--to=jeff@garzik.org \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-ide@vger.kernel.org \
--cc=linux@rainbow-software.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).