Re: [PATCH] ide: identify data word 53 bit 1 doesn't cover words 62 and 63

[Sergei Shtylyov <sshtylyov@ru.mvista.com>]

Hello, i wrote:

> The IDE code assumed for years that the but 1 of the identify data word 53 also
> covers SW/MW DMA information in words 62 and 63 but is has always covered only
> words 64 thru 70, with words 62 and 63 being defined by the original ATA spec.,
> not by ATA-2...
>
> This fix however should only concern *very* old hard disks and rather old CF
> cards...
>
> Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
>
> ---
> This patch is against the recent Linus' tree...
>
>  drivers/ide/ide-dma-sff.c |    5 ++---
>  drivers/ide/ide-dma.c     |   32 ++++++++++++++------------------
>  2 files changed, 16 insertions(+), 21 deletions(-)
>
> Index: linux-2.6/drivers/ide/ide-dma-sff.c
> ===================================================================
> --- linux-2.6.orig/drivers/ide/ide-dma-sff.c
> +++ linux-2.6/drivers/ide/ide-dma-sff.c
> @@ -38,9 +38,8 @@ int config_drive_for_dma(ide_drive_t *dr
>  	 * Enable DMA on any drive that has mode2 DMA
>  	 * (multi or single) enabled
>  	 */
> -	if (id[ATA_ID_FIELD_VALID] & 2)	/* regular DMA */
> -		if ((id[ATA_ID_MWDMA_MODES] & 0x404) == 0x404 ||
> -		    (id[ATA_ID_SWDMA_MODES] & 0x404) == 0x404)
> +	if ((id[ATA_ID_MWDMA_MODES] & 0x404) == 0x404 ||
> +	    (id[ATA_ID_SWDMA_MODES] & 0x404) == 0x404)
>  			return 1;
>   

   Oops, this needs to be moved to the left. I'll repost.

MBR, Sergei