From: Roel Kluin <roel.kluin@gmail.com>
To: jgarzik@redhat.com
Cc: linux-ide@vger.kernel.org, Andrew Morton <akpm@linux-foundation.org>
Subject: [PATCH] pata-rb532-cf: platform_get_irq() failure ignored
Date: Tue, 03 Mar 2009 14:04:26 +0100 [thread overview]
Message-ID: <49AD2ADA.5030109@gmail.com> (raw)
------------------------------>8-------------8<---------------------------------
platform_get_irq() can return -ENXIO, but since 'irq' is an unsigned int, it
does not show when the IRQ resource wasn't found.
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
diff --git a/drivers/ata/pata_rb532_cf.c b/drivers/ata/pata_rb532_cf.c
index ebfcda2..fe8178c 100644
--- a/drivers/ata/pata_rb532_cf.c
+++ b/drivers/ata/pata_rb532_cf.c
@@ -173,11 +173,12 @@ static __devinit int rb532_pata_driver_probe(struct platform_device *pdev)
return -EINVAL;
}
- irq = platform_get_irq(pdev, 0);
- if (irq <= 0) {
+ ret = platform_get_irq(pdev, 0);
+ if (ret <= 0) {
dev_err(&pdev->dev, "no IRQ resource found\n");
return -ENOENT;
}
+ irq = ret;
gpio = irq_to_gpio(irq);
if (gpio < 0) {
next reply other threads:[~2009-03-03 13:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-03 13:04 Roel Kluin [this message]
2009-03-05 12:23 ` [PATCH] pata-rb532-cf: platform_get_irq() failure ignored Jeff Garzik
2009-03-06 16:43 ` Phil Sutter
2009-03-13 14:41 ` Florian Fainelli
2009-03-14 0:51 ` Phil Sutter
2009-03-25 2:16 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49AD2ADA.5030109@gmail.com \
--to=roel.kluin@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=jgarzik@redhat.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).