linux-ide.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mark Lord <liml@rtr.ca>
To: Tejun Heo <tj@kernel.org>
Cc: IDE/ATA development list <linux-ide@vger.kernel.org>,
	Jeff Garzik <jeff@garzik.org>,
	stable@kernel.org, josephjang@gmail.com, mrsohn@gmail.com
Subject: Re: [PATCH #upstream-fixes, -stable] ata_piix: add workaround for Samsung DB-P70
Date: Tue, 03 Mar 2009 08:17:01 -0500	[thread overview]
Message-ID: <49AD2DCD.60807@rtr.ca> (raw)
In-Reply-To: <49ACB780.1070604@kernel.org>

Tejun Heo wrote:
> Samsung DB-P70 somehow botched the first ICH9 SATA port.  The board
> doesn't expose the first port but somehow SStatus reports link online
> while failing SRST protocol leading to repeated probe failures and
> thus long boot delay.
> 
> Because the BIOS doesn't carry any identifying DMI information, the
> port can't be blacklisted safely.  Fortunately, the controller does
> have subsystem vendor and ID set.  It's unclear whether the subsystem
> IDs are used only for the board but it can be safely worked around by
> disabling SIDPR access and just using SRST works around the problem.
> Even when the workaround is triggered on an unaffected board the only
> side effect will be missing SCR access.

..

A suggestion, then.  As a follow-up patch, would it be possible
to drop the workaround kludge, and restore the missing SCR access,
__after the first time that a drive is detected on that port__?

This way, there won't be any funny business for cases where
the same ID might occur on different (non-botched) hardware ?

Probably overkill, though.  :)

Cheers

  reply	other threads:[~2009-03-03 13:17 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-03  4:52 [PATCH #upstream-fixes, -stable] ata_piix: add workaround for Samsung DB-P70 Tejun Heo
2009-03-03 13:17 ` Mark Lord [this message]
2009-03-04  2:36   ` Tejun Heo
2009-03-04 15:52     ` Mark Lord
2009-03-13 18:58 ` Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49AD2DCD.60807@rtr.ca \
    --to=liml@rtr.ca \
    --cc=jeff@garzik.org \
    --cc=josephjang@gmail.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=mrsohn@gmail.com \
    --cc=stable@kernel.org \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).