From: Roel Kluin <roel.kluin@gmail.com>
To: Borislav Petkov <petkovbb@gmail.com>
Cc: linux-ide@vger.kernel.org, Andrew Morton <akpm@linux-foundation.org>
Subject: [PATCH] ide-cd: unsigned len subtracted below 0?
Date: Wed, 04 Mar 2009 00:13:46 +0100 [thread overview]
Message-ID: <49ADB9AA.106@gmail.com> (raw)
len is unsigned, so take care not to subtract below 0.
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
diff --git a/drivers/ide/ide-cd.c b/drivers/ide/ide-cd.c
index ddfbea4..23447a0 100644
--- a/drivers/ide/ide-cd.c
+++ b/drivers/ide/ide-cd.c
@@ -916,7 +916,10 @@ static ide_startstop_t cdrom_newpc_intr(ide_drive_t *drive)
xferfunc(drive, NULL, ptr, blen);
thislen -= blen;
- len -= blen;
+ if (blen > len)
+ len -= blen;
+ else
+ len = 0;
if (blk_fs_request(rq)) {
rq->buffer += blen;
next reply other threads:[~2009-03-03 23:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-03 23:13 Roel Kluin [this message]
2009-03-04 7:20 ` [PATCH] ide-cd: unsigned len subtracted below 0? Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49ADB9AA.106@gmail.com \
--to=roel.kluin@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-ide@vger.kernel.org \
--cc=petkovbb@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).