From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Lord Subject: Re: [PATCH #upstream-fixes, -stable] ata_piix: add workaround for Samsung DB-P70 Date: Wed, 04 Mar 2009 10:52:13 -0500 Message-ID: <49AEA3AD.1080309@rtr.ca> References: <49ACB780.1070604@kernel.org> <49AD2DCD.60807@rtr.ca> <49ADE934.6080105@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from rtr.ca ([76.10.145.34]:44041 "EHLO mail.rtr.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752150AbZCDPwQ (ORCPT ); Wed, 4 Mar 2009 10:52:16 -0500 In-Reply-To: <49ADE934.6080105@kernel.org> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Tejun Heo Cc: IDE/ATA development list , Jeff Garzik , stable@kernel.org, josephjang@gmail.com, mrsohn@gmail.com Tejun Heo wrote: > Hello, Mark. > > Mark Lord wrote: >> A suggestion, then. As a follow-up patch, would it be possible >> to drop the workaround kludge, and restore the missing SCR access, >> __after the first time that a drive is detected on that port__? > > Hmmm... yeah. Maybe but it would either involve changing ap->ops on > the fly (which is a big no no) or wrap SCR access such that it returns > -EOPNOTSUPP if the kludge is in effect. > >> This way, there won't be any funny business for cases where >> the same ID might occur on different (non-botched) hardware ? >> >> Probably overkill, though. :) > > Missing SCR access doesn't impact direct usage too much, so yeah I > think it should be fine as it is until there's some evidence that the > subsystem IDs are in far wider use. .. Perfectly sensible!