Re: [PATCH 2/3 v3] ide: add at91_ide driver

[Sergei Shtylyov <sshtylyov@ru.mvista.com>]

I wrote:

>>>> This is IDE host driver for AT91 (SAM9, CAP9, AT572D940HF) Static 
>>>> Memory
>>>> Controller with Compact Flash True IDE Mode logic.

>>>> Driver have to switch 8/16 bit bus width when accessing Task Tile or 
>>>> Data
>>>> Register. Moreover some extra things need to be done when setting 
>>>> PIO mode.
>>>> Only PIO mode is used, hardware have no DMA support. If interrupt 
>>>> line is
>>>> connected through GPIO extra quirk is needed to cope with fake 
>>>> interrupts.

>>>> Signed-off-by: Stanislaw Gruszka <stf_xl@wp.pl>

>>>    This is prolly only me, but I afil to compile this driver with the 
>>> current arch/arm/configs/at91sam9263ek_defconfig:

>>>   CC      drivers/ide/at91_ide.o
>>> drivers/ide/at91_ide.c: In function ‘at91_ide_input_data’:
>>> drivers/ide/at91_ide.c:159: error: implicit declaration of function 
>>> ‘__ide_mm_insw’
>>> drivers/ide/at91_ide.c: In function ‘at91_ide_output_data’:
>>> drivers/ide/at91_ide.c:174: error: implicit declaration of function 
>>> ‘__ide_mm_outsw’
>>> drivers/ide/at91_ide.c: In function ‘at91_ide_tf_load’:
>>> drivers/ide/at91_ide.c:192: error: ‘task’ undeclared (first use in 
>>> this function)
>>> drivers/ide/at91_ide.c:192: error: (Each undeclared identifier is 
>>> reported only
>>> once
>>> drivers/ide/at91_ide.c:192: error: for each function it appears in.)
>>> drivers/ide/at91_ide.c: At top level:
>>> drivers/ide/at91_ide.c:303: warning: initialization from incompatible 
>>> pointer type
>>> drivers/ide/at91_ide.c:304: warning: initialization from incompatible 
>>> pointer type
>>> make[1]: *** [drivers/ide/at91_ide.o] Error 1
>>> make: *** [drivers/ide/] Error 2

>>    Ah, it's only with pata-2.6 series applied. Bart, you clearly need 
>> to include this driver to some of your patches...

    Oops, got muddled in too many follow-ups. :-)
    Namely, ide-remove-ide_task_t-typedef.patch is incomplete...

>    ... and ide-add-flagged_tf_flags-to-struct-ide_taskfile-v2.patch too.

MBR, Sergei