From: Mark Lord <liml@rtr.ca>
To: Frans Pop <elendil@planet.nl>
Cc: linux-arm@vger.kernel.org, linux-ide@vger.kernel.org,
Saeed Bishara <saeed@marvell.com>, Nicolas Pitre <nico@cam.org>,
Lennert Buytenhek <buytenh@wantstofly.org>
Subject: Re: [PATCH,v2][1/2] sata-mv: enable HDD led blinking when NCQ is active for GenIIe
Date: Wed, 11 Mar 2009 08:47:05 -0400 [thread overview]
Message-ID: <49B7B2C9.10203@rtr.ca> (raw)
In-Reply-To: <200903110815.52650.elendil@planet.nl>
Frans Pop wrote:
..
> @@ -480,11 +487,19 @@ struct mv_hw_ops {
> unsigned int port);
> void (*enable_leds)(struct mv_host_priv *hpriv, void __iomem *mmio);
> void (*read_preamp)(struct mv_host_priv *hpriv, int idx,
> - void __iomem *mmio);
> + void __iomem *mmio);
> int (*reset_hc)(struct mv_host_priv *hpriv, void __iomem *mmio,
> unsigned int n_hc);
> void (*reset_flash)(struct mv_host_priv *hpriv, void __iomem *mmio);
> void (*reset_bus)(struct ata_host *host, void __iomem *mmio);
> + void (*enable_led_blink)(struct mv_host_priv *hpriv,
> + void __iomem *mmio, int enable_blink);
> +
> + /*
> + * ->inherits must be the last field and all the preceding
> + * fields must be pointers.
> + */
> + const struct mv_hw_ops *inherits;
> };
..
>
> +static const struct mv_hw_ops mv6xxx_iie_ops = {
> + .inherits = &mv6xxx_ops,
> + .enable_led_blink = mv_iie_enable_led_blink,
> +};
> +
I'm afraid I just don't understand the purpose of "inherits" above.
This field appears to never be referenced anywhere.
(or did I miss an update to the C programming language at some point? :)
???
next prev parent reply other threads:[~2009-03-11 12:47 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-11 7:13 [PATCH,v2][0/2] sata_mv: harddisk activity led no longer responsive on QNAP TS-109 Frans Pop
2009-03-11 7:15 ` [PATCH,v2][1/2] sata-mv: enable HDD led blinking when NCQ is active for GenIIe Frans Pop
2009-03-11 12:47 ` Mark Lord [this message]
2009-03-11 13:08 ` Frans Pop
2009-03-11 14:15 ` Mark Lord
2009-03-12 11:40 ` Frans Pop
2009-03-12 14:14 ` Mark Lord
2009-03-12 14:15 ` Mark Lord
2009-03-12 14:26 ` Mark Lord
2009-03-13 8:07 ` Frans Pop
2009-03-13 13:04 ` Mark Lord
2009-03-13 18:19 ` Frans Pop
2009-03-13 19:09 ` Mark Lord
2009-03-14 11:57 ` Frans Pop
2009-03-14 14:53 ` Mark Lord
2009-03-15 10:18 ` Frans Pop
2009-03-12 14:27 ` Frans Pop
2009-03-12 14:31 ` Mark Lord
2009-03-11 7:17 ` [PATCH,v2][2/2] sata-mv: add module parameter msq_blink_led to enable quirk " Frans Pop
2009-03-11 12:33 ` [PATCH,v2][0/2] sata_mv: harddisk activity led no longer responsive on QNAP TS-109 Mark Lord
2009-03-11 12:58 ` Mark Lord
2009-03-11 13:01 ` Frans Pop
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49B7B2C9.10203@rtr.ca \
--to=liml@rtr.ca \
--cc=buytenh@wantstofly.org \
--cc=elendil@planet.nl \
--cc=linux-arm@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=nico@cam.org \
--cc=saeed@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).