linux-ide.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mark Lord <liml@rtr.ca>
To: Norman Diamond <n0diamond@yahoo.co.jp>
Cc: Jim Paris <jim@jtan.com>,
	linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org,
	Robert Hancock <hancockrwd@gmail.com>,
	Alan Cox <alan@lxorguk.ukuu.org.uk>,
	Sergei Shtylyov <sshtylyov@ru.mvista.com>,
	Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Subject: Re: Off-by-one in both LIBATA and IDE drivers
Date: Thu, 12 Mar 2009 10:30:48 -0400	[thread overview]
Message-ID: <49B91C98.4090309@rtr.ca> (raw)
In-Reply-To: <9CEE6A51B15649D3ABEBD9BE0241A345@DIAMOND8600>

Norman Diamond wrote:
> Jim Paris wrote:
>> Norman Diamond wrote:
>>>
>>> It looks like both LIBATA and the old IDE drivers have an off-by-one 
>>> error in deciding whether to use READ SECTOR(S) instead of READ 
>>> SECTOR(S) EXT.
>>
>> This was fixed here:
>> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=97b697a11b07e2ebfa69c488132596cc5eb24119 
>>
> 
> I'm still having trouble after applying the same patch to 2.6.24.3 
> (applying it three times in order to build Slax).  But now I wonder if 
> it's no longer the fault of drivers.
> 
> Does hdparm construct its own taskfiles for ATA and SATA in order to 
> produce an error trying to read sector number 0x0fffffff even after I 
> patched the kernel?
..

What, *exactly*, do you mean there.
Yes, hdparm constructs its own taskfiles for the --read-sector subcommand.
Are you hitting these errors with the latest hdparm (9.12)?

???

  reply	other threads:[~2009-03-12 14:30 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-11  1:50 Off-by-one in both LIBATA and IDE drivers Norman Diamond
2009-03-11  3:03 ` Jim Paris
2009-03-11  3:28   ` Norman Diamond
     [not found]     ` <49B78859.5050807@ru.mvista.com>
2009-03-11 21:03       ` Norman Diamond
2009-03-12 11:20   ` Norman Diamond
2009-03-12 14:30     ` Mark Lord [this message]
2009-03-12 23:02       ` Norman Diamond
2009-03-13  7:41         ` Norman Diamond
2009-03-13 14:45           ` Robert Hancock
2009-03-14  2:05             ` Norman Diamond
2009-03-14  2:15               ` Robert Hancock
2009-03-14  8:48                 ` Alan Cox
2009-03-14  9:34                   ` Norman Diamond
2009-03-14 10:48                     ` Alan Cox
2009-03-14  8:46               ` Alan Cox
2009-03-11  8:27 ` Alan Cox
2009-03-11  8:38   ` Norman Diamond
2009-03-12  0:10     ` Robert Hancock
2009-03-12  2:28       ` Norman Diamond
2009-03-12  4:26         ` Robert Hancock

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49B91C98.4090309@rtr.ca \
    --to=liml@rtr.ca \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=bzolnier@gmail.com \
    --cc=hancockrwd@gmail.com \
    --cc=jim@jtan.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=n0diamond@yahoo.co.jp \
    --cc=sshtylyov@ru.mvista.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).