From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Lord Subject: Re: Off-by-one in both LIBATA and IDE drivers Date: Thu, 12 Mar 2009 10:30:48 -0400 Message-ID: <49B91C98.4090309@rtr.ca> References: <20090311015039.42922.qmail@web4115.mail.ogk.yahoo.co.jp> <20090311030340.GA617@psychosis.jim.sh> <9CEE6A51B15649D3ABEBD9BE0241A345@DIAMOND8600> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from rtr.ca ([76.10.145.34]:38385 "EHLO mail.rtr.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754551AbZCLOaw (ORCPT ); Thu, 12 Mar 2009 10:30:52 -0400 In-Reply-To: <9CEE6A51B15649D3ABEBD9BE0241A345@DIAMOND8600> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Norman Diamond Cc: Jim Paris , linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org, Robert Hancock , Alan Cox , Sergei Shtylyov , Bartlomiej Zolnierkiewicz Norman Diamond wrote: > Jim Paris wrote: >> Norman Diamond wrote: >>> >>> It looks like both LIBATA and the old IDE drivers have an off-by-one >>> error in deciding whether to use READ SECTOR(S) instead of READ >>> SECTOR(S) EXT. >> >> This was fixed here: >> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=97b697a11b07e2ebfa69c488132596cc5eb24119 >> > > I'm still having trouble after applying the same patch to 2.6.24.3 > (applying it three times in order to build Slax). But now I wonder if > it's no longer the fault of drivers. > > Does hdparm construct its own taskfiles for ATA and SATA in order to > produce an error trying to read sector number 0x0fffffff even after I > patched the kernel? .. What, *exactly*, do you mean there. Yes, hdparm constructs its own taskfiles for the --read-sector subcommand. Are you hitting these errors with the latest hdparm (9.12)? ???