From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
To: "Erik Inge Bolsø" <knan-lkml@anduin.net>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>, linux-ide@vger.kernel.org
Subject: Re: [PATCH 20/73] pata_efar: use ata.h mode mask defines
Date: Sat, 14 Mar 2009 23:40:35 +0300 [thread overview]
Message-ID: <49BC1643.9020201@ru.mvista.com> (raw)
In-Reply-To: <alpine.BSF.1.00.0903142045250.61753@anduin.net>
Hello.
Erik Inge Bolsø wrote:
>>> No functional changes in this patch.
>>> (Looks like it could use one, though.)
>>>
>> Yep - wrong comment. The EFAR is a sort of clone of the PIIX and I copied
>> the comment while EFAR don't appear to have copied the limitation
>>
>
> Most suspicious thing I noted here was 0x0F = UDMA3, though. You probably
> meant UDMA4?
>
> Will send bugfix patches after I redo the pure conversion in two patches,
> like Jeff says.
>
It makes more sense to put the fixes *before* the cleanups.
MBR, Sergei
next prev parent reply other threads:[~2009-03-14 20:40 UTC|newest]
Thread overview: 87+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-14 18:35 [PATCH 00/73] libata: use ata.h mode mask defines everywhere Erik Inge Bolsø
2009-03-14 19:07 ` [PATCH 01/73] pata_acpi: use ata.h mode mask defines Erik Inge Bolsø
2009-03-14 19:10 ` [PATCH 02/73] [ide/ata]: add ATA_MWDMA3 and ATA_MWDMA4 masks Erik Inge Bolsø
2009-03-14 19:23 ` Jeff Garzik
2009-03-14 19:30 ` Erik Inge Bolsø
2009-03-14 19:42 ` Alan Cox
2009-03-14 19:56 ` Jeff Garzik
2009-03-14 20:00 ` Erik Inge Bolsø
2009-03-14 19:10 ` [PATCH 03/73] pata_octeon_cf: use ata.h mode mask defines Erik Inge Bolsø
2009-03-14 19:11 ` [PATCH 04/73] ahci: " Erik Inge Bolsø
2009-03-14 19:11 ` [PATCH 05/73] ata_generic: " Erik Inge Bolsø
2009-03-14 19:11 ` [PATCH 06/73] ata_piix: " Erik Inge Bolsø
2009-03-14 19:11 ` [PATCH 07/73] pata_ali: " Erik Inge Bolsø
2009-03-14 19:11 ` [PATCH 08/73] pata_amd: " Erik Inge Bolsø
2009-03-14 19:11 ` [PATCH 09/73] pata_artop: " Erik Inge Bolsø
2009-03-14 19:12 ` [PATCH 10/73] pata_at32: " Erik Inge Bolsø
2009-03-14 19:21 ` Jeff Garzik
2009-03-14 19:12 ` [PATCH 11/73] pata_atiixp: " Erik Inge Bolsø
2009-03-14 19:12 ` [PATCH 12/73] pata_bf54x: " Erik Inge Bolsø
2009-03-14 19:13 ` [PATCH 13/73] pata_cmd640: " Erik Inge Bolsø
2009-03-14 19:13 ` [PATCH 14/73] pata_cmd64x: " Erik Inge Bolsø
2009-03-14 19:13 ` [PATCH 15/73] pata_cs5520: " Erik Inge Bolsø
2009-03-14 19:13 ` [PATCH 16/73] pata_cs5530: " Erik Inge Bolsø
2009-03-14 19:13 ` [PATCH 17/73] pata_cs5535: " Erik Inge Bolsø
2009-03-14 19:14 ` [PATCH 18/73] pata_cs5536: " Erik Inge Bolsø
2009-03-14 19:14 ` [PATCH 19/73] pata_cypress: " Erik Inge Bolsø
2009-03-14 19:14 ` [PATCH 20/73] pata_efar: " Erik Inge Bolsø
2009-03-14 19:45 ` Alan Cox
2009-03-14 19:48 ` Erik Inge Bolsø
2009-03-14 20:40 ` Sergei Shtylyov [this message]
2009-03-14 22:10 ` Jeff Garzik
2009-03-14 19:14 ` [PATCH 21/73] pata_hpt366: " Erik Inge Bolsø
2009-03-14 19:14 ` [PATCH 22/73] pata_hpt37x: " Erik Inge Bolsø
2009-03-14 19:14 ` [PATCH 23/73] pata_hpt3x2n: " Erik Inge Bolsø
2009-03-14 19:15 ` [PATCH 24/73] pata_hpt3x3: " Erik Inge Bolsø
2009-03-14 19:15 ` [PATCH 25/73] pata_icside: " Erik Inge Bolsø
2009-03-14 19:15 ` [PATCH 26/73] pata_isapnp: " Erik Inge Bolsø
2009-03-14 19:15 ` [PATCH 27/73] pata_it8213: " Erik Inge Bolsø
2009-03-14 19:15 ` [PATCH 28/73] pata_it821x: " Erik Inge Bolsø
2009-03-14 19:15 ` [PATCH 29/73] pata_ixp4xx_cf: " Erik Inge Bolsø
2009-03-14 19:16 ` [PATCH 30/73] pata_jmicron: " Erik Inge Bolsø
2009-03-14 19:16 ` [PATCH 31/73] pata_legacy: " Erik Inge Bolsø
2009-03-14 19:16 ` [PATCH 32/73] pata_marvell: " Erik Inge Bolsø
2009-03-14 19:17 ` [PATCH 33/73] pata_mpc52xx: " Erik Inge Bolsø
2009-03-14 19:17 ` [PATCH 34/73] pata_mpiix: " Erik Inge Bolsø
2009-03-14 19:17 ` [PATCH 35/73] pata_netcell: " Erik Inge Bolsø
2009-03-14 19:17 ` [PATCH 36/73] pata_ninja32: " Erik Inge Bolsø
2009-03-14 19:18 ` [PATCH 37/73] pata_ns87410: " Erik Inge Bolsø
2009-03-14 19:18 ` [PATCH 38/73] pata_ns87415: " Erik Inge Bolsø
2009-03-14 19:18 ` [PATCH 39/73] pata_oldpiix: " Erik Inge Bolsø
2009-03-14 19:18 ` [PATCH 40/73] pata_opti: " Erik Inge Bolsø
2009-03-14 19:18 ` [PATCH 41/73] pata_optidma: " Erik Inge Bolsø
2009-03-14 19:19 ` [PATCH 42/73] pata_pcmcia: " Erik Inge Bolsø
2009-03-14 19:19 ` [PATCH 43/73] pata_pdc2027x: " Erik Inge Bolsø
2009-03-14 19:19 ` [PATCH 44/73] pata_pdc202xx_old: " Erik Inge Bolsø
2009-03-14 19:19 ` [PATCH 45/73] pata_qdi: " Erik Inge Bolsø
2009-03-14 19:19 ` [PATCH 46/73] pata_radisys: use ata.h mode mask defines, add ATA_UDMA24_ONLY Erik Inge Bolsø
2009-03-14 19:35 ` Jeff Garzik
2009-03-14 19:44 ` Alan Cox
2009-03-14 19:19 ` [PATCH 47/73] pata_rb532_cf: use ata.h mode mask defines Erik Inge Bolsø
2009-03-14 19:20 ` [PATCH 48/73] pata_rz1000: " Erik Inge Bolsø
2009-03-14 19:20 ` [PATCH 49/73] pata_sc1200: " Erik Inge Bolsø
2009-03-14 19:20 ` [PATCH 50/73] pata_scc: " Erik Inge Bolsø
2009-03-14 19:20 ` [PATCH 51/73] pata_sch: remove superfluous mode mask comments Erik Inge Bolsø
2009-03-14 19:20 ` [PATCH 52/73] pata_serverworks: use ata.h mode mask defines Erik Inge Bolsø
2009-03-14 19:20 ` [PATCH 53/73] pata_sil680: " Erik Inge Bolsø
2009-03-14 19:20 ` [PATCH 54/73] pata_sis: " Erik Inge Bolsø
2009-03-14 19:21 ` [PATCH 55/73] pata_sl82c105: " Erik Inge Bolsø
2009-03-14 19:21 ` [PATCH 56/73] pata_triflex: " Erik Inge Bolsø
2009-03-14 19:21 ` [PATCH 57/73] pata_via: " Erik Inge Bolsø
2009-03-14 19:21 ` [PATCH 58/73] pata_winbond: " Erik Inge Bolsø
2009-03-14 19:21 ` [PATCH 59/73] pdc_adma: use ata.h mode mask defines, add ATA_PIO4_ONLY Erik Inge Bolsø
2009-03-14 19:34 ` Jeff Garzik
2009-03-14 19:21 ` [PATCH 60/73] sata_fsl: use ata.h mode mask defines Erik Inge Bolsø
2009-03-14 19:21 ` [PATCH 61/73] sata_inic162x: " Erik Inge Bolsø
2009-03-14 19:22 ` [PATCH 62/73] sata_mv: " Erik Inge Bolsø
2009-03-14 19:22 ` [PATCH 63/73] sata_nv: " Erik Inge Bolsø
2009-03-14 19:22 ` [PATCH 64/73] sata_promise: " Erik Inge Bolsø
2009-03-14 19:22 ` [PATCH 65/73] sata_qstor: " Erik Inge Bolsø
2009-03-14 19:22 ` [PATCH 66/73] sata_sil24: " Erik Inge Bolsø
2009-03-14 19:22 ` [PATCH 67/73] sata_sil: " Erik Inge Bolsø
2009-03-14 19:22 ` [PATCH 68/73] sata_sis: " Erik Inge Bolsø
2009-03-14 19:23 ` [PATCH 69/73] sata_svw: " Erik Inge Bolsø
2009-03-14 19:23 ` [PATCH 70/73] sata_sx4: " Erik Inge Bolsø
2009-03-14 19:23 ` [PATCH 71/73] sata_uli: " Erik Inge Bolsø
2009-03-14 19:24 ` [PATCH 72/73] sata_via: " Erik Inge Bolsø
2009-03-14 19:24 ` [PATCH 73/73] sata_vsc: " Erik Inge Bolsø
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49BC1643.9020201@ru.mvista.com \
--to=sshtylyov@ru.mvista.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=knan-lkml@anduin.net \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).