From: Tejun Heo <tj@kernel.org>
To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>,
IDE/ATA development list <linux-ide@vger.kernel.org>
Subject: bug in use-ide_pio_bytes patch?
Date: Mon, 23 Mar 2009 15:28:43 +0900 [thread overview]
Message-ID: <49C72C1B.5080601@kernel.org> (raw)
Hello, Bartlomiej.
I've been looking at the pata-2.6 patches and use-ide_pio_bytes patch
contains the following snippet.
void ide_init_pc(struct ide_atapi_pc *pc)
{
memset(pc, 0, sizeof(*pc));
@@ -351,6 +308,9 @@ static ide_startstop_t ide_pc_intr(ide_d
pc->xferred = pc->req_xfer;
if (drive->pc_update_buffers)
drive->pc_update_buffers(drive, pc);
+
+ if (drive->media == ide_floppy)
+ ide_complete_rq(drive, 0, blk_rq_bytes(rq));
}
debug_log("%s: DMA finished\n", drive->name);
}
It completes ide_floppy requests in the DMA handling block; however,
those requests are gonna be completed again later in the regular
completion path again. I think the above part can be simply dropped?
Thanks.
--
tejun
next reply other threads:[~2009-03-23 6:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-23 6:28 Tejun Heo [this message]
2009-03-23 10:27 ` bug in use-ide_pio_bytes patch? Bartlomiej Zolnierkiewicz
2009-03-23 10:44 ` Tejun Heo
2009-03-23 11:43 ` Bartlomiej Zolnierkiewicz
2009-03-25 9:15 ` Borislav Petkov
2009-03-26 20:19 ` Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49C72C1B.5080601@kernel.org \
--to=tj@kernel.org \
--cc=bzolnier@gmail.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).