From: Tejun Heo <htejun@gmail.com>
To: Sagar Borikar <sagar.borikar@gmail.com>
Cc: jgarzik@pobox.com, linux-ide@vger.kernel.org
Subject: Re: [PATCH] Removing PCI dependency of ahci and making it amba bus compatible
Date: Fri, 27 Mar 2009 10:10:10 +0900 [thread overview]
Message-ID: <49CC2772.7080205@gmail.com> (raw)
In-Reply-To: <49CC2704.7050102@kernel.org>
Hello,
Tejun Heo wrote:
> Sagar Borikar wrote:
>> Currently ahci driver assumes that the SATA controller is hooked up
>> to the PCI. There are couple of devices like Synopsis Designware SATA
>> controller with ahci sits on AHB interface and not on PCI. This patch
>> is currently tied up to our platform and I have removed PCI dependent
>> calls from the the driver. I still have to make it bus independent.
>> Please review the patch and let me know if its fine.
>>
>> All comments are welcome. Also please note that this is not
>> replacement of the existing ahci.c file I am going to create a new
>> file for ahci_ahb.c But for review, I have compared against ahci.c
>> Thanks
>
> Sagar, the amba changes look fine although I have no way of verifying
> whether it works or not, but you just converted ahci from pci
> dependent to amba dependent. The patch can't really be merged unless
> we're willing to break all PCI ahci systems in favor of the amba one.
> :-)
Oops, you already mentioned this. Sorry about not reading before
replying.
--
tejun
next prev parent reply other threads:[~2009-03-27 1:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-26 14:00 [PATCH] Removing PCI dependency of ahci and making it amba bus compatible Sagar Borikar
2009-03-27 1:08 ` Tejun Heo
2009-03-27 1:10 ` Tejun Heo [this message]
2009-03-29 22:46 ` Jeff Garzik
[not found] ` <3fb94e50903291900x2caac3c7nc30c842015570089@mail.gmail.com>
2009-03-30 2:26 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49CC2772.7080205@gmail.com \
--to=htejun@gmail.com \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=sagar.borikar@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).