From: Mark Lord <liml@rtr.ca>
To: Jeff Garzik <jgarzik@pobox.com>,
IDE/ATA development list <linux-ide@vger.kernel.org>
Cc: Maxime Bizon <mbizon@freebox.fr>,
Lennert Buytenhek <buytenh@marvell.com>,
Saeed Bishara <saeed@marvell.com>
Subject: [PATCH 01/03] sata_mv: revert SoC irq breakage
Date: Mon, 06 Apr 2009 12:29:49 -0400 [thread overview]
Message-ID: <49DA2DFD.4010402@rtr.ca> (raw)
Revert most of commit 6be96ac1d5e4d913e1f48299db083ada5321803b2,
originally from Lennert Buijtenheck (Marvell) and Saeed Bishara (Marvell),
since that commit causes sata_mv to oops at startup on SOC "Kirkwood".
The SOC variants do not have the hpriv->irq_{cause,mask}_ofs registers,
so don't try to write to them!
This patch should also be considered for -stable.
Reported-by: Maxime Bizon <mbizon@freebox.fr>
Signed-off-by: Mark Lord <mlord@pobox.com>
---
Note: I am mostly in the dark about the sata_mv SOC stuff,
since I have incomplete documentation and no hardware to test with.
--- old/drivers/ata/sata_mv.c 2009-04-06 11:18:01.000000000 -0400
+++ new/drivers/ata/sata_mv.c 2009-04-06 11:59:57.000000000 -0400
@@ -3734,11 +3734,13 @@
writelfl(0, hc_mmio + HC_IRQ_CAUSE_OFS);
}
- /* Clear any currently outstanding host interrupt conditions */
- writelfl(0, mmio + hpriv->irq_cause_ofs);
+ if (!IS_SOC(hpriv)) {
+ /* Clear any currently outstanding host interrupt conditions */
+ writelfl(0, mmio + hpriv->irq_cause_ofs);
- /* and unmask interrupt generation for host regs */
- writelfl(hpriv->unmask_all_irqs, mmio + hpriv->irq_mask_ofs);
+ /* and unmask interrupt generation for host regs */
+ writelfl(hpriv->unmask_all_irqs, mmio + hpriv->irq_mask_ofs);
+ }
/*
* enable only global host interrupts for now.
next reply other threads:[~2009-04-06 16:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-06 16:29 Mark Lord [this message]
2009-04-06 16:30 ` [PATCH 02/03] sata_mv: fix irq mask races Mark Lord
2009-04-06 16:31 ` [PATCH 03/03] sata_mv: replace 0x1f with ATA_PIO4 Mark Lord
2009-04-06 19:22 ` [PATCH 03/03] sata_mv: replace 0x1f with ATA_PIO4 (v2) Mark Lord
2009-04-06 19:24 ` [PATCH 04/07] sata_mv: workaround errata PCI#7 Mark Lord
2009-04-06 19:24 ` [PATCH 05/07] sata_mv: workaround errata SATA#26 Mark Lord
2009-04-06 19:25 ` [PATCH 06/07] sata_mv: cosmetic renames Mark Lord
2009-04-06 19:26 ` [PATCH 07/07] sata_mv: workaround errata SATA#13 Mark Lord
2009-04-06 20:43 ` [PATCH 08/08] sata_mv: shorten register names Mark Lord
2009-04-06 19:51 ` [PATCH 06/07] sata_mv: cosmetic renames Jeff Garzik
2009-04-06 20:12 ` Mark Lord
2009-04-07 0:16 ` [PATCH 01/03] sata_mv: revert SoC irq breakage Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49DA2DFD.4010402@rtr.ca \
--to=liml@rtr.ca \
--cc=buytenh@marvell.com \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=mbizon@freebox.fr \
--cc=saeed@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).