From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
To: Stanislaw Gruszka <stf_xl@wp.pl>
Cc: linux-ide@vger.kernel.org
Subject: Re: [PATCH 1/2] at91_ide: remove unused ide_mm_{outb,inb}
Date: Tue, 07 Apr 2009 13:06:18 +0400 [thread overview]
Message-ID: <49DB178A.8060508@ru.mvista.com> (raw)
In-Reply-To: <200904062341.59908.stf_xl@wp.pl>
Hello.
Stanislaw Gruszka wrote:
> Signed-off-by: Stanislaw Gruszka <stf_xl@wp.pl>
>
[...]
> diff --git a/drivers/ide/at91_ide.c b/drivers/ide/at91_ide.c
> index 4f3725d..c48dc61 100644
> --- a/drivers/ide/at91_ide.c
> +++ b/drivers/ide/at91_ide.c
> @@ -174,16 +174,6 @@ static void at91_ide_output_data(ide_drive_t *drive, struct ide_cmd *cmd,
> leave_16bit(chipselect, mode);
> }
>
> -static u8 ide_mm_inb(unsigned long port)
> -{
> - return readb((void __iomem *) port);
> -}
> -
> -static void ide_mm_outb(u8 value, unsigned long port)
> -{
> - writeb(value, (void __iomem *) port);
> -}
> -
> static void at91_ide_set_pio_mode(ide_drive_t *drive, const u8 pio)
> {
> struct ide_timing *timing;
>
Oops, that should have been a part of my patch removing
at91_ide_tf_{load|read}(). I'll recast...
MBR, Sergei
next prev parent reply other threads:[~2009-04-07 9:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-07 3:41 [PATCH 1/2] at91_ide: remove unused ide_mm_{outb,inb} Stanislaw Gruszka
2009-04-07 9:06 ` Sergei Shtylyov [this message]
2009-04-07 18:30 ` Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49DB178A.8060508@ru.mvista.com \
--to=sshtylyov@ru.mvista.com \
--cc=linux-ide@vger.kernel.org \
--cc=stf_xl@wp.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).