From: Jeff Garzik <jeff@garzik.org>
To: Tejun Heo <htejun@gmail.com>
Cc: Linux IDE mailing list <linux-ide@vger.kernel.org>
Subject: [PATCH] libata-eh: call freeze hook before port abort
Date: Tue, 07 Apr 2009 17:38:57 -0400 [thread overview]
Message-ID: <49DBC7F1.3040801@garzik.org> (raw)
[-- Attachment #1: Type: text/plain, Size: 321 bytes --]
Tejun,
This patch looks like it might work for !PMP setups, but I am not so
sure about PMP.
Any comments? This should help begin addressing the problem where
hardware needs the DMA engine turned off before accessing the taskfile
registers -- something needed for ata_port_abort() via ata_qc_complete().
Jeff
[-- Attachment #2: patch --]
[-- Type: text/plain, Size: 377 bytes --]
diff --git a/drivers/ata/libata-eh.c b/drivers/ata/libata-eh.c
index 0183131..0b7ed40 100644
--- a/drivers/ata/libata-eh.c
+++ b/drivers/ata/libata-eh.c
@@ -1013,8 +1013,8 @@ int ata_port_freeze(struct ata_port *ap)
WARN_ON(!ap->ops->error_handler);
- nr_aborted = ata_port_abort(ap);
__ata_port_freeze(ap);
+ nr_aborted = ata_port_abort(ap);
return nr_aborted;
}
next reply other threads:[~2009-04-07 21:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-07 21:38 Jeff Garzik [this message]
2009-04-07 22:58 ` [PATCH] libata-eh: call freeze hook before port abort Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49DBC7F1.3040801@garzik.org \
--to=jeff@garzik.org \
--cc=htejun@gmail.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).