From: Jeff Garzik <jeff@garzik.org>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Linux IDE mailing list <linux-ide@vger.kernel.org>
Subject: 32-bit IO to-do item...
Date: Thu, 09 Apr 2009 01:25:40 -0400 [thread overview]
Message-ID: <49DD86D4.3090304@garzik.org> (raw)
Alan,
I keep meaning to mention this (and get it into the mail archive)...
The 32-bit IO patch was incomplete, because it rendered
ATA_IOC_[GS]ET_IO32 handling in ata_sas_scsi_ioctl() -- our base ioctl
handler -- incorrect.
Previously, it simply ensured the ioctls reflected hardcoded 16-bit I/O.
Now, behavior no longer matches what the ioctls report.
At a minimum, drivers probably need to set an "I'm using 32bit I/O"
flag, that the ioctl then reads, replacing ata_sas_scsi_ioctl()'s
assumption that val==0.
Jeff
next reply other threads:[~2009-04-09 5:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-09 5:25 Jeff Garzik [this message]
2009-04-09 8:54 ` 32-bit IO to-do item Alan Cox
2009-04-09 9:48 ` Jeff Garzik
2009-04-09 10:22 ` Alan Cox
2009-04-09 11:03 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49DD86D4.3090304@garzik.org \
--to=jeff@garzik.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).