Re: [PROPOSED] ata: Report 16/32bit PIO as best we can

[Mark Lord <liml@rtr.ca>]

Alan Cox wrote:
> Something like this then ?
> 
> 
> The legacy old IDE API for this is a bit primitive so we try and map stuff
> sensibly onto it.
> 
> - Add flags2 as we ran out of flags
> - Set PIO over DMA devices to report 32bit
> - Add ability to change the PIO32 settings if the controller permits it
> - Add that functionality into the sff drivers
> - Add that functionality into the VLB legacy driver
> - Turn on the 32bit PIO on the ninja32 and add support there
> 
> Signed-off-by: Alan Cox <alan@linux.intel.com>
..

By all means go ahead with something like this,
and thanks for doing it, Alan.

But.. these do look rather suspiciously like sysfs attrs to me.

We didn't have a sysfs in the IDE days (so Gadi added the klunky
procfs "settings" thing for there), but we do now.

I'm happy to update hdparm to check sysfs if that's where this
ends up, or to do almost nothing for it if we stick with the ioctls.

Thanks either way!