From: Tejun Heo <tj@kernel.org>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Jeff Garzik <jeff@garzik.org>, linux-ide@vger.kernel.org
Subject: Re: [PROPOSED] ata: Report 16/32bit PIO as best we can
Date: Thu, 09 Apr 2009 06:45:08 -0700 [thread overview]
Message-ID: <49DDFBE4.40702@kernel.org> (raw)
In-Reply-To: <20090409141254.283d9f11@lxorguk.ukuu.org.uk>
Alan Cox wrote:
>> With the attached patch, you can use ->flags for the two new flags, and
>> you can set those bits in the driver where you set the other
>> ATA_FLAG_xxx bits.
>
> Its half way but I realised there is another reason that doesn't work
> (and indeed why the device private flags are asking for trouble)
>
> What are the locking sematics for ap->flags ?
ap->flags is owned by EH context and only EH can change it.
ap->pflags is for dynamic flags and can be changed under port lock by
anyone but I forgot why I named that pflags instead of dflags.
Thanks.
--
tejun
next prev parent reply other threads:[~2009-04-09 13:45 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-09 13:32 [PROPOSED] ata: Report 16/32bit PIO as best we can Alan Cox
2009-04-09 12:50 ` Jeff Garzik
2009-04-09 12:53 ` Alan Cox
2009-04-09 13:08 ` Jeff Garzik
2009-04-09 13:12 ` Alan Cox
2009-04-09 13:33 ` Jeff Garzik
2009-04-09 13:41 ` Alan Cox
2009-04-09 13:45 ` Jeff Garzik
2009-04-09 13:48 ` Tejun Heo
2009-04-09 13:49 ` Tejun Heo
2009-04-09 13:45 ` Tejun Heo [this message]
2009-04-09 13:58 ` Alan Cox
2009-04-09 14:02 ` Tejun Heo
2009-04-09 13:02 ` Mark Lord
2009-04-09 13:08 ` Alan Cox
2009-04-13 16:32 ` Jeff Garzik
2009-04-13 16:39 ` Alan Cox
2009-04-13 16:57 ` Jeff Garzik
2009-04-09 13:25 ` Jeff Garzik
2009-04-09 16:57 ` Mark Lord
2009-04-09 20:42 ` Jeff Garzik
2009-04-10 0:38 ` Douglas Gilbert
2009-04-10 0:47 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49DDFBE4.40702@kernel.org \
--to=tj@kernel.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).