From: Tejun Heo <tj@kernel.org>
To: Jeff Garzik <jeff@garzik.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Arjan van de Ven <arjan@infradead.org>, Mark Lord <lkml@rtr.ca>,
Theodore Tso <tytso@mit.edu>, Jens Axboe <jens.axboe@oracle.com>,
Linux Kernel Developers List <linux-kernel@vger.kernel.org>,
Linux IDE mailing list <linux-ide@vger.kernel.org>,
George Spelvin <linux@horizon.com>
Subject: Re: [PATCH libata: add SSD detection hueristic; move SSD setup to ata_dev_configure (was Re: [GIT PULL] Ext3 latency fixes)
Date: Thu, 09 Apr 2009 11:21:50 -0700 [thread overview]
Message-ID: <49DE3CBE.8030607@kernel.org> (raw)
In-Reply-To: <49DBAC42.4040003@garzik.org>
Jeff Garzik wrote:
> ata_id_string() or ata_id_c_string() is what you want.
>
> But yeah, we see what you're trying to illustrate.
>
> For internal reasons, it is better to detect and set up SSD details in
> ata_dev_configure(), where we detect and configure other ATA details.
>
> I've attached an example patch, compiled-tested only.
>
> If we wanted to get more fancy, we could extend the strn_pattern_cmp()
> function in libata to accept wildcard '*' prefixes, as well as suffixes.
> That would make it easy to auto-configure future ATA devices based on
> the product id (such as "G.SKILL 128GB SSD").
There was an shell globbing patch floating around which would be
pretty nice to have for pattern matchings like this. cc'ing the patch
author. George, what happened to the patch?
Thanks.
--
tejun
next prev parent reply other threads:[~2009-04-09 18:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <alpine.LFD.2.00.0904031150190.4015@localhost.localdomain>
[not found] ` <alpine.LFD.2.00.0904031329410.7007@localhost.localdomain>
[not found] ` <20090404135719.GA9812@mit.edu>
[not found] ` <20090404151649.GE5178@kernel.dk>
[not found] ` <alpine.LFD.2.00.0904040854470.3915@localhost.localdomain>
[not found] ` <20090404173412.GF5178@kernel.dk>
[not found] ` <alpine.LFD.2.00.0904041039230.3915@localhost.localdomain>
[not found] ` <20090404180108.GH5178@kernel.dk>
[not found] ` <20090404232222.GA7480@mit.edu>
[not found] ` <20090404163349.20df1208@infradead.org>
[not found] ` <20090405001005.GA7553@mit.edu>
[not found] ` <alpine.LFD.2.00.0904050927580.4023@localhost.localdomain>
[not found] ` <49D8E71F.6000703@rtr.ca>
[not found] ` <49D91B31.90300@garzik.org>
[not found] ` <20090405164831.7ad01c20@infradead.org>
[not found] ` <49D99775.9030104@garzik.org>
[not found] ` <alpine.LFD.2.00.0904071107500.27889@localhost.localdomain>
2009-04-07 19:40 ` [PATCH libata: add SSD detection hueristic; move SSD setup to ata_dev_configure (was Re: [GIT PULL] Ext3 latency fixes) Jeff Garzik
2009-04-09 18:21 ` Tejun Heo [this message]
2009-04-18 3:02 ` George Spelvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49DE3CBE.8030607@kernel.org \
--to=tj@kernel.org \
--cc=arjan@infradead.org \
--cc=jeff@garzik.org \
--cc=jens.axboe@oracle.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@horizon.com \
--cc=lkml@rtr.ca \
--cc=torvalds@linux-foundation.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).