From: Jeff Garzik <jeff@garzik.org>
To: saeed bishara <saeed.bishara@gmail.com>
Cc: Grant Grundler <grundler@google.com>,
Saeed Bishara <saeed@marvell.com>, Mark Lord <liml@rtr.ca>,
linux-ide@vger.kernel.org, Martin Michlmayr <tbm@cyrius.com>
Subject: Re: [PATCH] sata_mv: use new sata phy register settings for new devices
Date: Mon, 13 Apr 2009 03:34:04 -0400 [thread overview]
Message-ID: <49E2EAEC.5030606@garzik.org> (raw)
In-Reply-To: <c70ff3ad0904130026r4aac1ef4le36175ecdfed581c@mail.gmail.com>
saeed bishara wrote:
>> Any chance these magic numbers can be documented?
>>
>> No objection to this patch and I would prefer a follow on
>> patch to document the bits if that's possible.
> Grant,
> those bits control analog/electrical settings of the sata phy
> module, the functional spec uses acronyms to name it, and without much
> documentation for it.
Named constants based on acronyms are preferable to numeric constants.
A little information and disambiguation is better than none at all.
Jeff
next prev parent reply other threads:[~2009-04-13 7:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-11 16:08 [PATCH] sata_mv: use new sata phy register settings for new devices Martin Michlmayr
2009-04-11 22:02 ` Grant Grundler
2009-04-13 7:26 ` saeed bishara
2009-04-13 7:34 ` Jeff Garzik [this message]
2009-04-22 10:44 ` saeed bishara
2009-05-04 18:58 ` Martin Michlmayr
2009-05-04 23:43 ` Mark Lord
2009-05-11 18:34 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49E2EAEC.5030606@garzik.org \
--to=jeff@garzik.org \
--cc=grundler@google.com \
--cc=liml@rtr.ca \
--cc=linux-ide@vger.kernel.org \
--cc=saeed.bishara@gmail.com \
--cc=saeed@marvell.com \
--cc=tbm@cyrius.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).