Re: [PATCH] sata_sx4: refresh and convert to new EH

[Jeff Garzik <jeff@garzik.org>]

Alexander Beregalov wrote:
> 2009/4/12 Jeff Garzik <jeff@garzik.org>:
>> Alexander Beregalov wrote:
>>> 2009/4/9 Jeff Garzik <jeff@garzik.org>:
>>>> I reviewed and refreshed libata-dev.git#new-eh, now renamed to #sx4.
>>>>
>>>> Several bugs and missing pieces in the new-EH conversion were addressed
>>>> (often by copying highly similar code from sata_promise, a highly
>>>> similar chip)
>>>>
>>>> The only thing left is some "it still works" testing...  any takers?
>>>>
>>> Hi Jeff
>>>
>>> I have SX4000 card, it is based on the same PDC20621 chip, but has PATA
>>> ports
>>> (without PATA-SATA bridges).
>>> Can I help?
>>>
>>> I am newbie here, but I will try to modify the driver to support PATA
>>> card as well
>>> and test your patch.
>> It's unknown how well, or what is needed, to support the SX4000.  You are
>> welcome to dive in and figure out what is needed, but you'd be asking
>> questions to which we wouldn't have answers.
> 
> I found Promise provided docs for FreeBSD team.
> http://unix.derkeiler.com/Mailing-Lists/FreeBSD/performance/2003-07/0043.html

Well, you can find several docs at 
http://gkernel.sourceforge.net/specs/promise/


>> I do have the sx4000 in the works (thanks to Promise who has provided docs
>> and HW to make this happen)..
> Can we ask them too? :)
> 
> Interesting, I cut off all unrelated lines from freebsd/ata/ata-chipset.c
> and it seems SX4/SX4000 driver is only about 700 lines long.

The current FreeBSD has split up things into multiple files.  You can 
check out the kernel via

	cd $repo
	mkdir -p freebsd/src
	cd freebsd
	svn checkout svn://svn.freebsd.org/base/head/sys src/sys
	cd src/sys/dev/ata/chipsets

and indeed ata-promise.c has plenty of SX4[000] goodies to mess around with!

Also, check out this stuff from sata_promise maintainer Mikael:
http://marc.info/?l=linux-ide&m=121144512109826&w=2
http://marc.info/?l=linux-ide&m=121135828227724&w=2

My revised sata_sx4.c is currently stored on the "sx4" branch of
git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/libata-dev.git

	Jeff