From: Mark Lord <liml@rtr.ca>
To: saeed bishara <saeed.bishara@gmail.com>
Cc: Martin Michlmayr <tbm@cyrius.com>,
Saeed Bishara <saeed@marvell.com>,
linux-ide@vger.kernel.org
Subject: Re: [PATCH] sata_mv: increate the IORDY timeout for the soc controllers
Date: Mon, 13 Apr 2009 09:50:01 -0400 [thread overview]
Message-ID: <49E34309.1000306@rtr.ca> (raw)
In-Reply-To: <c70ff3ad0904130611u56f43d24me413e27b7bbb3b3d@mail.gmail.com>
saeed bishara wrote:
>>> PIO mode is always used, at least for the identify command. the patch
>>> works and needed for the Kirkwood SoC which runs at 200KHz.
>> ..
>>
>> Errr.. IDENTIFY is often a "special case" command,
>> and rarely, if ever, uses IORDY.
> I think you misunderstand the EDMA IORDY timer
..
Actually, I've been quite familiar with IORDY since 1992 or so.
It generally is only asserted when the drive is managing some
form of elastic buffer between the media and the ATA interface.
In the case of IDENTIFY, many drives will not need to access
the media (though some do), and as a result IORDY won't be used
to stretch the access cycles.
A far better test for your IORDY patch would be to actually use
PIO read/write commands to verify that it works correctly.
Cheers
prev parent reply other threads:[~2009-04-13 13:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-11 16:08 [PATCH] sata_mv: increate the IORDY timeout for the soc controllers Martin Michlmayr
2009-04-12 14:37 ` Mark Lord
2009-04-13 7:13 ` saeed bishara
2009-04-13 12:49 ` Mark Lord
2009-04-13 13:11 ` saeed bishara
2009-04-13 13:50 ` Mark Lord [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49E34309.1000306@rtr.ca \
--to=liml@rtr.ca \
--cc=linux-ide@vger.kernel.org \
--cc=saeed.bishara@gmail.com \
--cc=saeed@marvell.com \
--cc=tbm@cyrius.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).